Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in ToSocketAddrs documentation #46141

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Nov 20, 2017

Fix a typo in ToSocketAddrs documentation: s/ToSocketsAddr/ToSocketAddrs

Fix a typo in ToSocketAddrs documentation: s/ToSocketsAddr/ToSocketAddrs
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aqrln! This looks good to me.

@KodrAus
Copy link
Contributor

KodrAus commented Nov 21, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 21, 2017

@KodrAus: 🔑 Insufficient privileges: Not in reviewers

@KodrAus
Copy link
Contributor

KodrAus commented Nov 21, 2017

:(

@KodrAus
Copy link
Contributor

KodrAus commented Nov 21, 2017

r? @frewsxcv

@frewsxcv
Copy link
Member

thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 21, 2017

📌 Commit 0789a1d has been approved by frewsxcv

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 21, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 21, 2017
…=frewsxcv

Fix a typo in ToSocketAddrs documentation

Fix a typo in `ToSocketAddrs` documentation: s/ToSocketsAddr/ToSocketAddrs
bors added a commit that referenced this pull request Nov 21, 2017
Rollup of 11 pull requests

- Successful merges: #45987, #46031, #46050, #46052, #46103, #46120, #46134, #46141, #46148, #46155, #46157
- Failed merges:
@bors bors merged commit 0789a1d into rust-lang:master Nov 21, 2017
@aqrln aqrln deleted the tosocketaddrs-doc-fix-typo branch November 22, 2017 07:59
@aqrln
Copy link
Contributor Author

aqrln commented Nov 22, 2017

Thanks! Happy to have my first contribution to Rust and hope this isn't the last one :)

@aqrln
Copy link
Contributor Author

aqrln commented Jan 8, 2018

Hi! Today I noticed that the typo is still there at https://doc.rust-lang.org/std/net/trait.ToSocketAddrs.html. AFAICT the patch has never made it into any release. I'm not aware of the exact release process and policies but heads up if it should have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants