typeck aggregate rvalues in MIR type checker #46054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
arielb1
reviewed
Nov 19, 2017
| @@ -408,6 +411,11 @@ pub struct TypeChecker<'a, 'gcx: 'a + 'tcx, 'tcx: 'a> { | |||
| body_id: ast::NodeId, | |||
| reported_errors: FxHashSet<(Ty<'tcx>, Span)>, | |||
| constraints: MirTypeckRegionConstraints<'tcx>, | |||
|
|
|||
| // FIXME(#45940) - True if this is a MIR shim or ADT constructor | |||
There was a problem hiding this comment.
Isn't it a better idea to instead normalize field types in ADT constructors?
|
@arielb1 see latest commit. Tests seem to pass still. |
|
r=me with adt constructors being normalized in rustc_mir::shim instead of in type_check |
|
@bors r+ |
|
📌 Commit a59147c has been approved by |
kennytm
added
S-waiting-on-bors
nikomatsakis
force-pushed
the
nll-master-to-rust-master-1
branch
from
a59147c
to
c52e51d
Compare
|
@bors r=arielb1 (rebased) |
|
📌 Commit c52e51d has been approved by |
bors
added a commit
that referenced
this pull request
Nov 23, 2017
…ielb1 typeck aggregate rvalues in MIR type checker This branch is an attempt to land content by @spastorino and @Nashenas88 that was initially landed on nll-master while we waited for #45825 to land. The biggest change it contains is that it extends the MIR type-checker to also type-check MIR aggregate rvalues (at least partially). Specifically, it checks that the operands provided for each field have the right type. It does not yet check that their well-formedness predicates are met. That is #45827. It also does not check other kinds of rvalues (that is #45959). @spastorino is working on those issues now. r? @arielb1
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is an attempt to land content by @spastorino and @Nashenas88 that was initially landed on nll-master while we waited for #45825 to land.
The biggest change it contains is that it extends the MIR type-checker to also type-check MIR aggregate rvalues (at least partially). Specifically, it checks that the operands provided for each field have the right type.
It does not yet check that their well-formedness predicates are met. That is #45827. It also does not check other kinds of rvalues (that is #45959). @spastorino is working on those issues now.
r? @arielb1