check_unsafety: fix unused unsafe block duplication #45985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit bcaf685 has been approved by |
The duplicate error message is later removed by error message deduplication, but it still appears on beta and is still a bug
arielb1
force-pushed
the
unsafe-dedup
branch
from
bcaf685
to
c0f7cce
Compare
|
📌 Commit c0f7cce has been approved by |
Merged
kennytm
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 15, 2017
check_unsafety: fix unused unsafe block duplication The duplicate error message is later removed by error message deduplication, but it still appears on beta and is still a bug. r? @eddyb
|
💔 Test failed - status-travis |
|
Linker crashed (SIGBUS, not SIGSEGV) on macOS. cc @alexcrichton We've got a crash log! Same as those reported in #38878 though. We're just going to change the fix in #40422 to handle SIGBUS as well and call it a day. |
bors
added a commit
that referenced
this pull request
Nov 16, 2017
check_unsafety: fix unused unsafe block duplication The duplicate error message is later removed by error message deduplication, but it still appears on beta and is still a bug. r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Nov 18, 2017
Fix #38878 again — restart linker when seeing SIGBUS in additional to SIGSEGV. In #45985 (comment) we see a linker crashed due to Bus Error (signal 10) on macOS. The error was not caught by #40422 since the PR only handles Segmentation Fault (signal 11). The crash log indicates the problem is the same as #38878, so we just amend #40422 to include SIGBUS as well. (Additionally, modified how the crash logs are printed so that irrelevant logs are truly filtered out.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicate error message is later removed by error message
deduplication, but it still appears on beta and is still a bug.
r? @eddyb