Save the highlighted item when switching tab #45288
Conversation
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-author
src/librustdoc/html/static/main.js
Outdated
| @@ -696,39 +703,52 @@ | |||
| var search_input = document.getElementsByClassName('search-input')[0]; | |||
| search_input.onkeydown = null; | |||
| search_input.onkeydown = function(e) { | |||
| var actives = []; | |||
| var actives = [[], [], []]; | |||
| var current = 0; | |||
There was a problem hiding this comment.
What does this current store? Is it the same as the currentTab from the outer scope?
There was a problem hiding this comment.
No, it's a local one when we're iterating over tabs. I'll update the variable's name.
src/librustdoc/html/static/main.js
Outdated
| @@ -696,39 +703,52 @@ | |||
| var search_input = document.getElementsByClassName('search-input')[0]; | |||
| search_input.onkeydown = null; | |||
There was a problem hiding this comment.
Is that line still required?
There was a problem hiding this comment.
Nope. Removing it. Thanks for spotting it!
GuillaumeGomez
force-pushed
the
tab-key-binding
branch
from
63d4c3d to
2b5ff93
Compare
GuillaumeGomez
force-pushed
the
tab-key-binding
branch
from
2b5ff93 to
f442326
Compare
kennytm
added
S-waiting-on-review
|
Looks good! r=me when #45281 hits. This seems to be a superset of that PR, so hopefully it won't make a merge conflict. |
|
@bors: r=QuietMisdreavus |
|
📌 Commit f442326 has been approved by |
Save the highlighted item when switching tab To be merged after #45281. r? @rust-lang/docs
|
☀️ Test successful - status-appveyor, status-travis |
To be merged after #45281.
r? @rust-lang/docs