Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let htmldocck.py check for directories #44949

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

QuietMisdreavus
Copy link
Member

Since i messed this up during #44613, i wanted to codify this into the rustdoc tests to make sure that doesn't happen again.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@QuietMisdreavus
Copy link
Member Author

I checked locally to make sure when i invert a @has-dir that it fails when it's supposed to, but i don't think there's a compile-fail analog for rustdoc tests. >_>

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2017
@nikomatsakis
Copy link
Contributor

@bors r+

but i don't think there's a compile-fail analog for rustdoc tests

yeah... meta-testing is hard.

@bors
Copy link
Contributor

bors commented Oct 3, 2017

📌 Commit 5b59c4d has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Oct 3, 2017

⌛ Testing commit 5b59c4d with merge 4502e2a...

bors added a commit that referenced this pull request Oct 3, 2017
let htmldocck.py check for directories

Since i messed this up during #44613, i wanted to codify this into the rustdoc tests to make sure that doesn't happen again.
@bors
Copy link
Contributor

bors commented Oct 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4502e2a to master...

@bors bors merged commit 5b59c4d into rust-lang:master Oct 3, 2017
@QuietMisdreavus QuietMisdreavus deleted the rustdoctest-dirs branch February 26, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants