Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Generics from MethodSig to TraitItem and ImplItem #44766

Merged
merged 11 commits into from
Oct 24, 2017
Merged

Move Generics from MethodSig to TraitItem and ImplItem #44766

merged 11 commits into from
Oct 24, 2017
+107 −125

Commits on Oct 18, 2017

  1. Lifting Generics from MethodSig to TraitItem and ImplItem since we wa… 

    …nt to support generics in each variant of TraitItem and ImplItem
    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    f61394f View commit details
    Browse the repository at this point in the history

  2. Fixed tidy errors

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    e03447d View commit details
    Browse the repository at this point in the history

  3. Removed redundant generics visits

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    892e468 View commit details
    Browse the repository at this point in the history

  4. Lifted generics into TraitItem and ImplItem from MethodSig -- HIR now… 

    … matches AST
    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    bb30144 View commit details
    Browse the repository at this point in the history

  5. Fixed tidy errors

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    2095ac1 View commit details
    Browse the repository at this point in the history

  6. Fixing rustdoc

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    b43db76 View commit details
    Browse the repository at this point in the history

  7. Updated to latest rustfmt-nightly

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    86ae349 View commit details
    Browse the repository at this point in the history

  8. Removed Generics from FnKind::ItemFn in libsyntax

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    14c426d View commit details
    Browse the repository at this point in the history

  9. Revert "Updated to latest rustfmt-nightly" 

    This reverts commit a49157dc30bf7a163200b10d63a71b005a1376e3.
    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    6936871 View commit details
    Browse the repository at this point in the history

  10. Marking the tools as broken

    @sunjay
    sunjay committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    60bff8c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. update inherent_impls tests 

    Now that we are visiting things in a different order during lowering,
adding parameters winds up affecting the HirIds assigned to thinks in
the method body, whereas it didn't before. We could fix this by
reordering the order in which we visit `generics` during lowering, but
this feels very fragile. Seems better to just let typeck tables be
dirty here.
    @nikomatsakis
    nikomatsakis committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    4b0f004 View commit details
    Browse the repository at this point in the history