Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register fn-ptr coercion obligations out of a snapshot #44013

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Register fn-ptr coercion obligations out of a snapshot #44013

merged 2 commits into from
Aug 22, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Aug 21, 2017

Fixes #43923.

beta-nominating because regression.
r? @eddyb

arielb1 added 2 commits August 21, 2017 14:11
@arielb1
register fn-ptr coercion obligations out of a snapshot
e002634 
Fixes rust-lang#43923.
@arielb1
fix other cases of registering obligations in a snapshot
b47bcc2 
No test cases for these ones, but they would all ICE if they ever run
with a non-empty set of obligations.
@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2017
@eddyb
Copy link
Member

eddyb commented Aug 21, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 21, 2017

📌 Commit b47bcc2 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Aug 22, 2017

⌛ Testing commit b47bcc2 with merge 469a6f9...

bors added a commit that referenced this pull request Aug 22, 2017
@bors
Auto merge of #44013 - arielb1:coerce-snapshot, r=eddyb
469a6f9 
Register fn-ptr coercion obligations out of a snapshot

Fixes #43923.

beta-nominating because regression.
r? @eddyb
@bors
Copy link
Contributor

bors commented Aug 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 469a6f9 to master...

@bors bors merged commit b47bcc2 into rust-lang:master Aug 22, 2017
@alexcrichton alexcrichton mentioned this pull request Aug 23, 2017
Merged
6 tasks
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 23, 2017
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Small patch, fixes regression.

cc @rust-lang/compiler

bors added a commit that referenced this pull request Aug 23, 2017
@bors
Auto merge of #44062 - alexcrichton:beta-next, r=alexcrichton
dcf532b 
[beta] Final round of beta backports

Includes:

* [x] #43723
* [x] #43830
* [x] #43844
* [x] #44013
* [x] #44049
* [x] #43948
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arielb1 @eddyb @bors @nikomatsakis @alexcrichton