Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit StorageLive for box temporaries #43859

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Aug 14, 2017

We started emitting StorageDead, so we better emit the corrseponding
StorageLive to avoid problems.

cc #43772 rust-lang/miri#303

We started emitting StorageDead, so we better emit the corrseponding
StorageLive to avoid problems.
@arielb1
Copy link
Contributor Author

arielb1 commented Aug 14, 2017

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned pnkfelix Aug 14, 2017
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2017
@nagisa
Copy link
Member

nagisa commented Aug 14, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2017

📌 Commit e3495b2 has been approved by nagisa

@bors
Copy link
Contributor

bors commented Aug 15, 2017

⌛ Testing commit e3495b2 with merge f6a30bd...

bors added a commit that referenced this pull request Aug 15, 2017
emit StorageLive for box temporaries

We started emitting StorageDead, so we better emit the corrseponding
StorageLive to avoid problems.

cc #43772 rust-lang/miri#303
@bors
Copy link
Contributor

bors commented Aug 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing f6a30bd to master...

@bors bors merged commit e3495b2 into rust-lang:master Aug 15, 2017
@RalfJung
Copy link
Member

Thanks, this fixes the miri testsuite :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants