Cleanup some remains of hr_lifetime_in_assoc_type compatibility lint
#43543
Conversation
| @@ -6,8 +6,6 @@ error[E0308]: mismatched types | |||
| | | |||
| = note: expected type `fn(&'cx S) -> &'cx S` | |||
| found type `fn(&'a S) -> &S {bar::<'_>}` | |||
| = note: lifetime parameter `'b` declared on fn `bar` appears only in the return type, but here is required to be higher-ranked, which means that `'b` must appear in both argument and return types | |||
| = note: this error is the result of a recent bug fix; for more information, see issue #33685 <https://github.com/rust-lang/rust/issues/33685> | |||
There was a problem hiding this comment.
Yeah, so I think I kept a lot of that machinery precisely so that we could continue to generate these notes -- or at least the first one -- but it is a lot of "stuff" for a rather obscure corner case.
| }); | ||
| // does not appear in the inputs, but appears in the return type? early-bound. | ||
| if !constrained_by_input.regions.contains(&name) && | ||
| appears_in_output.regions.contains(&name) { |
There was a problem hiding this comment.
Nit: I prefer the temporary variables; seems easier to read to me, particularly since the body here is indented the same as the condition (in which case I would typically move the { to the next line). But .. whatever. =)
|
@bors r+ |
|
@bors: r=nikomatsakis |
|
📌 Commit 80cf3f9 has been approved by |
|
⌛ Testing commit 80cf3f9 with merge 1a5ac0b288c0a3c0d304b84d55b7c5eb44aedbff... |
|
Something's wrong with Travis, each mac jobs is running dozens of workers concurrently, making the mac jobs extremely slow and the time limit extended to at least 30 hours. Since one of the five jobs completed successfully at 4⅗ hours, and the queue is quite empty (2 PRs waiting as of now), let's keep them running for a while. (I'll cancel it if there are still no progress before 12:00 UTC) |
|
💔 Test failed - status-travis |
|
@bors retry macOS builds errored after running for 6.6 hours. Spurious error due to queuing problem on Travis. |
Cleanup some remains of `hr_lifetime_in_assoc_type` compatibility lint r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Fix ICE with elided lifetimes in return type of foreign functions cc #43567 This is for a preliminary crater/cargobomb run. Lifetime elision still produces a late-bound lifetime, but it is caught by the same check as catches `type F = for<'a> fn() -> &'a u8` and reported as an error. If the breakage is significant, I'll have to partially revert #43543 (all the stuff that was required for dealing with late bound lifetimes in this position). r? @eddyb
Fix ICE with elided lifetimes in return type of foreign functions cc #43567 This is for a preliminary crater/cargobomb run. Lifetime elision in foreign functions now works exactly like in other functions or function-like entities. If the breakage is significant, I'll have to partially revert #43543 (all the stuff that was required for dealing with late bound lifetimes in this position). r? @eddyb
Beta 20170928 Backports of: - Allow unused extern crate again #44825 - macros: fix bug in collecting trait and impl items with derives. #44757 - `--cap-lints allow` switches off `can_emit_warnings` #44627 - Update the libc submodule #44116 - limit and clear cache obligations opportunistically #44269 - clear out projection subobligations after they are processed #43999 - fix logic error in #44269's `prune_cache_value_obligations` #45065 - REVERTS #43543: Cleanup some remains of `hr_lifetime_in_assoc_type` compatibility lint:
r? @nikomatsakis