Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: allow distros to disable debuginfo-only-std #43297

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

infinity0
Copy link
Contributor

This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a similar patch) and Debian that automatically put all debuginfo in separate "debug symbol" packages.

This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the ./configure command line.

In theory, one could also do this via bootstrap/config.toml but it doesn't work currently due to #43295.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@cuviper
Copy link
Member

cuviper commented Jul 17, 2017

The implication is that I'll need to disable those explicitly, right?
e.g. --enable-debuginfo --disable-debuginfo-lines --disable-debuginfo-only-std

@infinity0
Copy link
Contributor Author

Right. Though in Debian I'm only passing --disable-debuginfo-only-std; since debuginfo = true works in config.toml.

I had assumed that --enable-debuginfo-lines is a strictly additive option useful on top of --enable-debuginfo but looking at the code seems it's redundant if debuginfo is already true (either via ./configure or config.toml).

@infinity0
Copy link
Contributor Author

The failing travis check seems to be due to an HTTP error page being retrieved instead of a script:

$ stamp sh -x -c "$RUN_SCRIPT"
/home/travis/stamp: line 1: syntax error near unexpected token `newline'
/home/travis/stamp: line 1: `<?xml version="1.0" encoding="UTF-8"?>'

40/41 of the other build jobs passed.

@arielb1
Copy link
Contributor

arielb1 commented Jul 18, 2017

The failing travis check seems to be due to an HTTP error page being retrieved instead of a script:

Sure. Only the "long" travis check is important.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 18, 2017

📌 Commit ffae5de has been approved by alexcrichton

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 18, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jul 18, 2017

@bors rollup

@bors
Copy link
Contributor

bors commented Jul 19, 2017

⌛ Testing commit ffae5de with merge bb5ab534d986a0e4e189732fb561c9aa412a0688...

@bors
Copy link
Contributor

bors commented Jul 19, 2017

💔 Test failed - status-appveyor

@nagbot-rs
Copy link

nagbot-rs commented Jul 19, 2017 via email

@bors
Copy link
Contributor

bors commented Jul 19, 2017

@nagbot-rs: 🔑 Insufficient privileges: and not in try users

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit ffae5de with merge 18d40d93e64191ccc9f2b8fd0c895ace028803e3...

@bors
Copy link
Contributor

bors commented Jul 21, 2017

💔 Test failed - status-travis

@TimNN
Copy link
Contributor

TimNN commented Jul 21, 2017

@bors retry

  • Spurious network failure, that seems to have fixed itself

TimNN added a commit to TimNN/rust that referenced this pull request Jul 21, 2017
configure: allow distros to disable debuginfo-only-std

This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a [similar patch](https://src.fedoraproject.org/cgit/rpms/rust.git/tree/rust-1.16.0-configure-no-override.patch)) and Debian that automatically put all debuginfo in separate "debug symbol" packages.

This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the `./configure` command line.

In theory, one could also do this via `bootstrap/config.toml` but it doesn't work currently due to rust-lang#43295.
bors added a commit that referenced this pull request Jul 21, 2017
Rollup of 8 pull requests

- Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 24, 2017
configure: allow distros to disable debuginfo-only-std

This allows builders to generate debugging information for everything, even in a stable release build. This is useful for distros like Fedora (already carrying a [similar patch](https://src.fedoraproject.org/cgit/rpms/rust.git/tree/rust-1.16.0-configure-no-override.patch)) and Debian that automatically put all debuginfo in separate "debug symbol" packages.

This commit preserves the default behaviour of switching these on when a non-dev channel is selected, but allows the user to override this via the `./configure` command line.

In theory, one could also do this via `bootstrap/config.toml` but it doesn't work currently due to rust-lang#43295.
bors added a commit that referenced this pull request Jul 24, 2017
Rollup of 11 pull requests

- Successful merges: #43297, #43322, #43342, #43361, #43366, #43374, #43379, #43401, #43421, #43428, #43446
- Failed merges:
@bors bors merged commit ffae5de into rust-lang:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants