Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sufficiently old or low-impact compatibility lints deny-by-default #42894

Merged
merged 4 commits into from
Jul 8, 2017

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jun 25, 2017

cc #39216
cc #36247
cc #37872
cc #38260
cc #40107
cc #42238

Needs crater run before proceeding.

r? @nikomatsakis

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2017
@nikomatsakis
Copy link
Contributor

Will start a crater run.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jun 27, 2017

Crater checklist:

@arielb1 arielb1 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2017
@nikomatsakis
Copy link
Contributor

Coverage

  • 10074 crates tested: 7486 working / 2137 broken / 50 regressed / 14 fixed / 387 unknown.

Regressions

  • There are 49 root regressions
  • There are 50 regressions

Root regressions, sorted by rank:

@bors
Copy link
Contributor

bors commented Jun 28, 2017

☔ The latest upstream changes (presumably #42417) made this pull request unmergeable. Please resolve the merge conflicts.

arqunis added a commit to serenity-rs/serenity that referenced this pull request Jun 28, 2017
@petrochenkov
Copy link
Contributor Author

patterns_in_fns_without_body:

  • libimagutil-0.2.0
  • html5ever-0.18.0
  • users-0.5.2
  • leveldb-0.8.3
  • theban_db-0.7.0
  • popcorn-blas-0.1.0
  • hado-0.1.0
  • jlens-0.0.1
  • zmtp-0.6.0
  • cfrp-0.0.4
  • hprose-0.1.0
  • nalgebra-lapack-0.4.0
  • opal-0.1.1
  • rft-0.1.0
  • rss-rs-0.3.2
  • rustbar-0.2.0
  • esprit-0.0.5
  • spatial-0.2.0-rc2
  • capi-0.0.3
  • glitter-0.1.1

pub_use_of_private_extern_crate:

  • rotor-0.6.3
  • bitflags-associated-constants-0.6.0
  • once-0.3.2
  • json_rpc-0.2.0
  • cuticula-0.2.0
  • qecs-0.0.7
  • stdx-0.0.1

parenthesized_params_in_types_and_modules:

  • twox-hash-1.1.0
  • encoding_rs-0.6.11
  • font-atlas-0.1.3
  • rust_RIBBIT-0.0.1

safe_extern_statics:

  • rl-sys-0.5.2
  • ralloc_shim-0.1.1
  • oniguruma-0.3.1
  • rcmark-0.1.0

missing_fragment_specifier:

  • hashpipe-0.1.1
  • runwhen-0.0.3
  • sem-0.1.0

legacy_directory_ownership:

  • atomic-0.3.3

resolve_trait_on_defaulted_unit:

  • rjq-0.3.0

spurious:

  • arrayvec-0.3.23
  • bitcoin-0.9.1
  • cronparse-0.5.1
  • arthas_derive-0.1.0
  • twiddle-0.3.0
  • altbitflags-0.1.0
  • reep-optionparser-urlencoded-0.2.0
  • rusoto_ds-0.27.0
  • veb-rs-0.1.1

@petrochenkov
Copy link
Contributor Author

Looks like patterns_in_fns_without_body is going to stay warn-by-default and I'll send PRs with fixes for the remaining issues.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 30, 2017
@alexcrichton
Copy link
Member

ping @petrochenkov just wanted to make sure this didn't fall off your radar

@nikomatsakis
Copy link
Contributor

Just been out of town. Working on my backlog now!

@nikomatsakis
Copy link
Contributor

@petrochenkov ok r=me when you feel this is ready to go

@petrochenkov
Copy link
Contributor Author

I'm going to send patches to affected crates this weekend, after that I'll land this PR then.

@petrochenkov
Copy link
Contributor Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Jul 8, 2017

📌 Commit 9196f87 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Jul 8, 2017

⌛ Testing commit 9196f87 with merge fb4fa60...

bors added a commit that referenced this pull request Jul 8, 2017
Make sufficiently old or low-impact compatibility lints deny-by-default

Needs crater run before proceeding.

r? @nikomatsakis
LinuxMercedes added a commit to LinuxMercedes/hashpipe that referenced this pull request Jul 8, 2017
Bump `clap` to fix the build on new versions of `rustc` (see [rust-lang/rust#42894](rust-lang/rust#42894) and [rust-lang/rust#40107](rust-lang/rust#40107) for details)
@bors
Copy link
Contributor

bors commented Jul 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing fb4fa60 to master...

@bors bors merged commit 9196f87 into rust-lang:master Jul 8, 2017
@petrochenkov petrochenkov deleted the deny branch August 26, 2017 00:16
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 4, 2021
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 5, 2021
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2021
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Mar 5, 2021
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Mar 5, 2021
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint

This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)).

Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions.
So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants