Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Fix compiler docs yet again #42806

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jun 21, 2017

Add support for -Z force-unstable-if-unmarked to rustdoc.

r? @alexcrichton

Add support for `-Z force-unstable-if-unmarked` to rustdoc.
@alexcrichton
Copy link
Member

Hm this seems like it's not quite the right fix to me, what's the error message that you were seeing? How come this was settled on as a strategy for fixing the error?

@ollie27
Copy link
Member Author

ollie27 commented Jun 21, 2017

The error message is:

Documenting stage2 compiler (x86_64-pc-windows-msvc)
 Documenting arena v0.0.0 (file:///E:/Source/rust/src/libarena)
 Documenting rustc-serialize v0.3.24
 Documenting fmt_macros v0.0.0 (file:///E:/Source/rust/src/libfmt_macros)
 Documenting rustc_platform_intrinsics v0.0.0 (file:///E:/Source/rust/src/librustc_platform_intrinsics)
 Documenting log v0.3.8
 Documenting bitflags v0.8.2
 Documenting serialize v0.0.0 (file:///E:/Source/rust/src/libserialize)
 Documenting gcc v0.3.51
error: use of unstable library feature 'rustc_private': mainly needed for compiler internals (see issue #27812)
   --> src\libfmt_macros\lib.rs:422:34
    |
422 |             Some(&(pos, c)) if c.is_xid_start() => {
    |                                  ^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable

error: use of unstable library feature 'rustc_private': mainly needed for compiler internals (see issue #27812)
   --> src\libfmt_macros\lib.rs:431:18
    |
431 |             if c.is_xid_continue() {
    |                  ^^^^^^^^^^^^^^^
    |
    = help: add #![feature(rustc_private)] to the crate attributes to enable

error: Compilation failed, aborting rustdoc

error: Could not document `fmt_macros`.

I don't know how else to add #![feature(rustc_private)] and this is how rustc does it.

@alexcrichton
Copy link
Member

Ok, thanks for the info! Sounds good to me.

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 21, 2017

📌 Commit ae1dc2a has been approved by alexcrichton

@frewsxcv
Copy link
Member

@bors rollup

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
…alexcrichton

rustbuild: Fix compiler docs yet again

Add support for `-Z force-unstable-if-unmarked` to rustdoc.

r? @alexcrichton
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 22, 2017
…alexcrichton

rustbuild: Fix compiler docs yet again

Add support for `-Z force-unstable-if-unmarked` to rustdoc.

r? @alexcrichton
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017
…alexcrichton

rustbuild: Fix compiler docs yet again

Add support for `-Z force-unstable-if-unmarked` to rustdoc.

r? @alexcrichton
bors added a commit that referenced this pull request Jun 22, 2017
Rollup of 4 pull requests

- Successful merges: #42799, #42804, #42805, #42806
- Failed merges:
@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2017
@bors bors merged commit ae1dc2a into rust-lang:master Jun 22, 2017
@ollie27 ollie27 deleted the rustbuild_compiler_docs branch June 22, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants