-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compiling rustc without LLVM #42752
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
This would allow miri to run on platforms without llvm like redox os |
Note that @steveklabnik is currently working on a rewrite of rustdoc to get rid of most compiler dependencies, not sure if you want to duplicate work here. |
@est31 thanks for pointing me to that! Will remove the commit with rustdoc changes later this day. |
17ebb33
to
06d9fc5
Compare
☔ The latest upstream changes (presumably #42664) made this pull request unmergeable. Please resolve the merge conflicts. |
Doesn't yet compile when `llvm-enabled = false` due to crate metadata loading needing LLVM
6cd811b
to
2e2501b
Compare
Neat project. There's quite a lot of cfg in the driver. Seems like a bit of a smell. And the driver is actually sliced up to completely remove trans. Eventually we would expect this to be more refined, with trans supporting multiple backends, and disabling llvm just disabling one particular backend. It might be more elegant here to sink all the driver cfg into trans, and have trans itself report that there is no backend. |
Actually Rustc and LLVM now work under Redox (as part of my Google Summer of Code project to make Redox OS self-hosting). Of course that doesn't invalidate this PR which has many other potential benefits, but I thought I might as well mention it. |
@ids1024 didn't know. |
Closing in favor of #42932. |
Support compiling rustc without LLVM (try 2) Now doesn't change rustc_driver. Supersedes #42752
Doesn't yet compile without llvm enabled.
Todo:
Error log when not using llvm:
Edit: remove getting rustdoc working from todo list.