-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Bound to libcore. #42268
Move Bound to libcore. #42268
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Looks like travis failed:
|
Indeed it did. I'm not quite sure why, though, because those nodes do have stability attributes. |
I'm looking around and trying to find the rationale for this (I've forgotten at this point), can you remind me the reason for this move? |
@alexcrichton this is basically a prerequisite for moving |
Hm sorry but forgive my ignorance, why do we want to do that? |
@alexcrichton considering how the |
Hm so we don't tend to move types around "just because", can you elaborate on the rationale for moving these types into |
I mean, it gives you the ability to operate on
|
3d9f4d7
to
69a450c
Compare
Also I added stability markers to the |
da06f57
to
9003062
Compare
Link checker found a few problems.
|
/// An inclusive bound. | ||
#[stable(feature = "collections_bound", since = "1.17.0")] | ||
Included( | ||
#[stable(feature = "collections_bound", since = "1.17.0")] // ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these // ???
annotations? This is just how the stability check works.
I personally feel like we're not quite ready to do this yet. This seems to put us into a sort of "half baked" state where we have a stable |
Sounds good to me! Also the reason why I added the ???s was because they weren't required on the enum before I moved it. I've never seen the linter require stability attributes for the inside of tuple variants/structs before. |
Closing and moving the discussion to #30877. |
Half of a redone version of #41460. This creates a new module,
core::collections
, which currently only contains this type.