Don't ICE with nested enums in missing docs lint. #42262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
added
the
S-waiting-on-review
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
force-pushed
the
issue-40350
branch
from
305089b to
1e760fb
Compare
This also simplifies the lint by not storing variant depth or the struct def stack, because we no longer need them.
Mark-Simulacrum
force-pushed
the
issue-40350
branch
from
1e760fb to
918875f
Compare
|
@eddyb I believe I updated code per our discussion in IRC. |
|
@bors r+ |
|
📌 Commit 918875f has been approved by |
bors
added a commit
that referenced
this pull request
May 29, 2017
Don't ICE with nested enums in missing docs lint. Fixes #40350.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40350.