Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make submodule clones shallow to avoid work. #42208

Closed
wants to merge 1 commit into from
Closed

Make submodule clones shallow to avoid work. #42208

wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

This hopefully makes the situation on AppVeyor at least a little better.

r? @aidanhs

@Mark-Simulacrum
Make submodule clones shallow to avoid work.
da2b86f 
This hopefully makes the situation on AppVeyor at least a little better.
@Mark-Simulacrum
Copy link
Member Author

@bors r=aidanhs p=100

This will hopefully resolve our appveyor timeouts, so we want to land this. @aidanhs gave approval on IRC.

@bors
Copy link
Contributor

bors commented May 25, 2017

📌 Commit da2b86f has been approved by aidanhs

@bors
Copy link
Contributor

bors commented May 25, 2017

⌛ Testing commit da2b86f with merge 1027611...

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 25, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42208 - Mark-Simulacrum:shallow-submodules,…
3223da4 
… r=aidanhs

Make submodule clones shallow to avoid work.

This hopefully makes the situation on AppVeyor at least a little better.

r? @aidanhs
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 25, 2017
Closed
@Mark-Simulacrum
Copy link
Member Author

@bors retry

Might as well get the rollup started

@bors
Copy link
Contributor

bors commented May 25, 2017

⌛ Testing commit da2b86f with merge 5ed68e0...

@bors
Copy link
Contributor

bors commented May 25, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member Author

This approach won't quite work, an alternative is being worked on.

@Mark-Simulacrum Mark-Simulacrum deleted the shallow-submodules branch May 25, 2017 00:31
@est31 est31 mentioned this pull request Jun 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aidanhs aidanhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mark-Simulacrum @bors @aidanhs