Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: break into 2 sentences #41896

Merged
merged 1 commit into from
May 13, 2017
Merged

doc: break into 2 sentences #41896

merged 1 commit into from
May 13, 2017

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik
steveklabnik suggested changes May 10, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with this reflowed properly

src/libstd/thread/mod.rs Outdated
/// not specified either, a sensible default size will be set (2MB as
/// of the writting of this doc).
/// will be the `RUST_MIN_STACK` environment variable.
/// If it is not specified either, a sensible default will be set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you re-flow this? I agree splitting the sentences makes a lot of sense, but now it's got weird newlines.

@TimNN TimNN added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 10, 2017
@tshepang
Copy link
Member Author

is done

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you ❤️

@bors
Copy link
Contributor

bors commented May 11, 2017

📌 Commit e42875c has been approved by steveklabnik

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
0d29661 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
1db0f2b 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
5fc8373 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
abb729d 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
2826e77 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
bors added a commit that referenced this pull request May 12, 2017
@bors
Auto merge of #41954 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
0cf9c52 
Rollup of 15 pull requests

- Successful merges: #41820, #41843, #41847, #41860, #41896, #41912, #41916, #41918, #41919, #41921, #41923, #41934, #41940, #41942, #41943
- Failed merges: #41914
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41896 - tshepang:too-long, r=steveklabnik
605d727 
doc: break into 2 sentences
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 13, 2017
Merged
bors added a commit that referenced this pull request May 13, 2017
@bors
Auto merge of #41965 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
ef3ec5e 
Rollup of 15 pull requests

- Successful merges: #41820, #41860, #41876, #41896, #41912, #41916, #41918, #41921, #41923, #41934, #41935, #41940, #41942, #41943, #41951
- Failed merges:
@bors bors merged commit e42875c into rust-lang:master May 13, 2017
@tshepang tshepang deleted the too-long branch May 13, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik requested changes

Assignees

@brson brson

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tshepang @rust-highfive @steveklabnik @bors @brson @TimNN