Delete features which are easily removed, in libsyntax #41729
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hi @ubsan, looks like this has failed travis because the Cargo.lock needs updating as well? |
aidanhs
added
the
S-waiting-on-author
|
@aidanhs ah, dang |
|
Hopefully that fixes it. |
src/libsyntax/parse/mod.rs
Outdated
| @@ -261,10 +261,14 @@ pub fn char_lit(lit: &str) -> (char, isize) { | |||
| } | |||
| } | |||
|
|
|||
| pub fn escape_default(s: &str) -> String { | |||
| s.chars().map(char::escape_default).flat_map(|x| x).collect() | |||
There was a problem hiding this comment.
nit: indentation is weird here.
There was a problem hiding this comment.
oh, right, I use a different style from rustc.
|
Could some features from /rust/src/libsyntax_pos$ git grep '\[feature'
lib.rs:26:#![feature(const_fn)]
lib.rs:27:#![feature(custom_attribute)]
lib.rs:28:#![feature(optin_builtin_traits)]
lib.rs:30:#![feature(rustc_private)]
lib.rs:31:#![feature(staged_api)]
lib.rs:32:#![feature(specialization)] |
|
@kennytm it's a lot harder. The only one you can delete without changing quite a bit of code is |
|
@ubsan I see, thanks. I thought they are pulled in also due to bitflags. |
Mark-Simulacrum
added
S-waiting-on-review
|
I think this is done, though commits could be squashed. |
|
@Mark-Simulacrum done |
|
@bors: r+ |
|
📌 Commit 0be8758 has been approved by |
Delete features which are easily removed, in libsyntax
|
☀️ Test successful - status-appveyor, status-travis |
No description provided.