Expanded docs and examples for PathBuf::file_name and friends #41376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ rollup thank you! |
|
📌 Commit 652589f has been approved by |
|
Oops, fixed a misplaced paren in a doc test. |
aidanhs
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit c129312 has been approved by |
frewsxcv
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 20, 2017
|
☔ The latest upstream changes (presumably #41411) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
|
Rebased and integrated with the changes from #41348. |
|
@bors r+ rollup |
|
📌 Commit 3b4d34d has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 20, 2017
Expanded docs and examples for PathBuf::file_name and friends This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file. r? @steveklabnik
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Apr 21, 2017
Expanded docs and examples for PathBuf::file_name and friends This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file. r? @steveklabnik
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Apr 21, 2017
Expanded docs and examples for PathBuf::file_name and friends This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file. r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 21, 2017
Expanded docs and examples for PathBuf::file_name and friends This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file. r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 21, 2017
Expanded docs and examples for PathBuf::file_name and friends This addresses some common surprises when `PathBuf::set_file_name` is called on the path of a directory rather than a file. r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some common surprises when
PathBuf::set_file_nameis called on the path of a directory rather than a file.r? @steveklabnik