-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable errexit for sanity checking git repo #41147
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit b6de319 has been approved by |
@bors p=1 |
src/ci/init_repo.sh
Outdated
@@ -41,8 +41,10 @@ if [ ! -f "$cache_valid_file" ]; then | |||
rm -rf "$CACHE_DIR" | |||
mkdir "$CACHE_DIR" | |||
else | |||
set +o errexit | |||
stat_lines=$(cd "$cache_src_dir" && git status --porcelain | wc -l) | |||
stat_ec=$(cd "$cache_src_dir" && git status >/dev/null 2>&1 && echo $?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not part of this PR, but the && echo $?
seems a bit suspicious to me -- since &&
is used $?
should always be 0
here, right?
⌛ Testing commit b6de319 with merge 5fa0023... |
💔 Test failed - status-appveyor |
b6de319
to
bd4f381
Compare
@bors r+ |
📌 Commit bd4f381 has been approved by |
⌛ Testing commit bd4f381 with merge 535ba87... |
💔 Test failed - status-appveyor |
Test failure seems legit. |
|
Yeah, looks legit, but unrelated to this PR? @bors retry |
⌛ Testing commit bd4f381 with merge e3693bd... |
@bora retry Homu is stuck |
@bors retry |
⌛ Testing commit bd4f381 with merge 6b68d9a... |
💔 Test failed - status-appveyor |
Disable errexit for sanity checking git repo Unblock appveyor
☀️ Test successful - status-appveyor, status-travis |
Unblock appveyor