Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable errexit for sanity checking git repo #41147

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Apr 7, 2017

Unblock appveyor

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2017

📌 Commit b6de319 has been approved by TimNN

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

@bors p=1

@@ -41,8 +41,10 @@ if [ ! -f "$cache_valid_file" ]; then
rm -rf "$CACHE_DIR"
mkdir "$CACHE_DIR"
else
set +o errexit
stat_lines=$(cd "$cache_src_dir" && git status --porcelain | wc -l)
stat_ec=$(cd "$cache_src_dir" && git status >/dev/null 2>&1 && echo $?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not part of this PR, but the && echo $? seems a bit suspicious to me -- since && is used $? should always be 0 here, right?

@bors
Copy link
Contributor

bors commented Apr 7, 2017

⌛ Testing commit b6de319 with merge 5fa0023...

@bors
Copy link
Contributor

bors commented Apr 7, 2017

💔 Test failed - status-appveyor

@aidanhs aidanhs force-pushed the aphs-fix-appveyor-cache branch from b6de319 to bd4f381 Compare April 7, 2017 19:15
@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2017

📌 Commit bd4f381 has been approved by TimNN

@bors
Copy link
Contributor

bors commented Apr 7, 2017

⌛ Testing commit bd4f381 with merge 535ba87...

@bors
Copy link
Contributor

bors commented Apr 7, 2017

💔 Test failed - status-appveyor

@frewsxcv
Copy link
Member

frewsxcv commented Apr 7, 2017

Test failure seems legit.

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

[01:33:06] ---- test_release_ignore_panic stdout ----
[01:33:06] 	test
[01:33:06] running `C:\projects\rust\build\ct\cargo\target\debug\cargo test -v`
[01:33:06] bench
[01:33:06] running `C:\projects\rust\build\ct\cargo\target\debug\cargo bench -v`
[01:33:06] thread 'test_release_ignore_panic' panicked at '
[01:33:06] Expected: execs
[01:33:06]     but: exited with exit code: 3221225477
[01:33:06] --- stdout
[01:33:06] 
[01:33:06] --- stderr
[01:33:06]    Compiling a v0.0.1 (file:///C:/projects/rust/build/ct/cargo/target/cit/t53/foo/a)
[01:33:06]      Running `rustc --crate-name a a\src\lib.rs --crate-type lib --emit=dep-info,link -C opt-level=3 -C metadata=850c3cbe05004df2 -C extra-filename=-850c3cbe05004df2 --out-dir C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps -L dependency=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps`
[01:33:06]    Compiling foo v0.0.1 (file:///C:/projects/rust/build/ct/cargo/target/cit/t53/foo)
[01:33:06]      Running `rustc --crate-name foo src\lib.rs --emit=dep-info,link -C opt-level=3 --test -C metadata=4f826724f99492b5 -C extra-filename=-4f826724f99492b5 --out-dir C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps -L dependency=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps --extern a=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps\liba-850c3cbe05004df2.rlib`
[01:33:06]     Finished release [optimized] target(s) in 0.61 secs
[01:33:06]      Running `C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\release\deps\foo-4f826724f99492b5.exe --bench`
[01:33:06] error: bench failed
[01:33:06] ', C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\hamcrest-0.1.1\src\core.rs:31
[01:33:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:33:06] 
[01:33:06] 
[01:33:06] failures:
[01:33:06]     test_release_ignore_panic
[01:33:06] 
[01:33:06] test result: FAILED. 61 passed; 1 failed; 0 ignored; 0 measured
[01:33:06] 
[01:33:06] error: test failed
[01:33:06] thread 'main' panicked at 'tests failed for https://github.com/rust-lang/cargo', src\tools\cargotest\main.rs:98
[01:33:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:33:06] 
[01:33:06] 
[01:33:06] command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools\\x86_64-pc-windows-msvc\\release\\cargotest.exe" "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "C:\\projects\\rust\\build\\ct"
[01:33:06] expected success, got: exit code: 101

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

Yeah, looks legit, but unrelated to this PR?

@bors retry

@bors
Copy link
Contributor

bors commented Apr 7, 2017

⌛ Testing commit bd4f381 with merge e3693bd...

@frewsxcv
Copy link
Member

frewsxcv commented Apr 8, 2017

@bora retry

Homu is stuck

@frewsxcv
Copy link
Member

frewsxcv commented Apr 8, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Apr 8, 2017

⌛ Testing commit bd4f381 with merge 6b68d9a...

@bors
Copy link
Contributor

bors commented Apr 8, 2017

💔 Test failed - status-appveyor

@frewsxcv
Copy link
Member

frewsxcv commented Apr 8, 2017

@bors retry #40546

@bors
Copy link
Contributor

bors commented Apr 8, 2017

⌛ Testing commit bd4f381 with merge 547c12b...

bors added a commit that referenced this pull request Apr 8, 2017
Disable errexit for sanity checking git repo

Unblock appveyor
@bors
Copy link
Contributor

bors commented Apr 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing 547c12b to master...

@bors bors merged commit bd4f381 into rust-lang:master Apr 8, 2017
@aidanhs aidanhs deleted the aphs-fix-appveyor-cache branch April 8, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants