Allow using Vec::<T>::place_back for T: !Clone #40909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The place_back was likely put into block with `T: Clone` bound by mistake.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
My bad! |
|
@bors r+ |
|
📌 Commit 1e3bc5a has been approved by |
|
⌛ Testing commit 1e3bc5a with merge 47cd926... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 1e3bc5a has been approved by |
|
This PR is still reflected as failed on the queue, despite the approval or the retry. |
|
@bors: retry |
|
⌛ Testing commit 1e3bc5a with merge 495862b... |
|
💔 Test failed - status-travis |
|
The constraints per impl block are a vestige of older Rust anyway, it should be cleaned up (a single impl block for the inherent methods). |
|
… On Sun, Apr 2, 2017 at 8:17 PM, bluss ***@***.***> wrote:
The constraints per impl block are a vestige of older Rust anyway, it
should be cleaned up (a single impl block for the inherent methods).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#40909 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PUAoIf1o6_bJvbD5p2NpR54pyfHks5rsFbCgaJpZM4Mtf1i>
.
|
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 5, 2017
…chton Allow using Vec::<T>::place_back for T: !Clone The place_back was likely put into block with `T: Clone` bound by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The place_back was likely put into block with
T: Clonebound by mistake.