Update the book submodule and fix tidy #40732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ rollup thanks! There's some other good fixes in here too; some changes were merged into the book that regressed when this landed, I made the fixes in the upstream repo, and was planning on doing this myself later in the week 👍 Side note: My goal is to end up submitting these kinds of updates every week or so, rather than after every fix to the upstream repo. That way we don't end up spamming this repo with update PRs. |
|
📌 Commit 9e772b0 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 22, 2017
Update the book submodule and fix tidy When the book was included into https://github.com/rust-lang/rust as a submodule, tidy started failing on Windows. rust-lang/book#549 fixed the problem, now the submodule needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the book was included into https://github.com/rust-lang/rust as a submodule, tidy started failing on Windows.
rust-lang/book#549 fixed the problem, now the submodule needs to be updated.