Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Don't cache stdio handles on Windows #40516

Merged
merged 1 commit into from
Mar 29, 2017
Merged

std: Don't cache stdio handles on Windows #40516

merged 1 commit into from
Mar 29, 2017

Conversation

alexcrichton
Copy link
Member

This alters the stdio code on Windows to always call GetStdHandle whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls SetStdHandle while it's running).

Closes #40490

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton mentioned this pull request Mar 14, 2017
Closed
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 14, 2017
@aturon
Copy link
Member

aturon commented Mar 21, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit af72b06 has been approved by aturon

@bors
Copy link
Contributor

bors commented Mar 23, 2017

🔒 Merge conflict

@alexcrichton
std: Don't cache stdio handles on Windows
5ca8a73 
This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes rust-lang#40490
@alexcrichton
Copy link
Member Author

@bors: r=aturon

@bors
Copy link
Contributor

bors commented Mar 23, 2017

📌 Commit 5ca8a73 has been approved by aturon

@bors
Copy link
Contributor

bors commented Mar 24, 2017

⌛ Testing commit 5ca8a73 with merge b1d0e15...

@bors
Copy link
Contributor

bors commented Mar 24, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 25, 2017
@alexcrichton
Rollup merge of rust-lang#40516 - alexcrichton:no-cache-handles, r=at…
22380e7 
…uron

std: Don't cache stdio handles on Windows

This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes rust-lang#40490
@alexcrichton alexcrichton mentioned this pull request Mar 25, 2017
Closed
bors added a commit that referenced this pull request Mar 25, 2017
@bors
Auto merge of #40810 - alexcrichton:rollup, r=alexcrichton
40ae49a 
Rollup of 11 pull requests

- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
bors added a commit that referenced this pull request Mar 25, 2017
@bors
Auto merge of #40810 - alexcrichton:rollup, r=alexcrichton
ed9108d 
Rollup of 11 pull requests

- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
@bors
Copy link
Contributor

bors commented Mar 25, 2017

⌛ Testing commit 5ca8a73 with merge d11f245...

@bors
Copy link
Contributor

bors commented Mar 25, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor

arielb1 commented Mar 25, 2017

@bors
Copy link
Contributor

bors commented Mar 25, 2017

⌛ Testing commit 5ca8a73 with merge 25c8108...

@bors
Copy link
Contributor

bors commented Mar 25, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor

arielb1 commented Mar 25, 2017

@bors
Copy link
Contributor

bors commented Mar 25, 2017

⌛ Testing commit 5ca8a73 with merge f4f9468...

@bors
Copy link
Contributor

bors commented Mar 25, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor

arielb1 commented Mar 25, 2017

@bors
Copy link
Contributor

bors commented Mar 26, 2017

⌛ Testing commit 5ca8a73 with merge c65e7de...

bors added a commit that referenced this pull request Mar 26, 2017
@bors
Auto merge of #40516 - alexcrichton:no-cache-handles, r=aturon
c65e7de 
std: Don't cache stdio handles on Windows

This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes #40490
@bors
Copy link
Contributor

bors commented Mar 26, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

alexcrichton commented Mar 27, 2017 via email

@bors
Copy link
Contributor

bors commented Mar 27, 2017

⌛ Testing commit 5ca8a73 with merge 71123e4...

bors added a commit that referenced this pull request Mar 27, 2017
@bors
Auto merge of #40516 - alexcrichton:no-cache-handles, r=aturon
71123e4 
std: Don't cache stdio handles on Windows

This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes #40490
@bors bors mentioned this pull request Mar 27, 2017
Merged
@arielb1
Copy link
Contributor

arielb1 commented Mar 27, 2017 •
edited
Loading

test [debuginfo-gdb] debuginfo-gdb\basic-types-globals-metadata.rs has been running for over 60 seconds
https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2588/job/cw6jsfpfa6ih0krm

@bors retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
@alexcrichton
Rollup merge of rust-lang#40516 - alexcrichton:no-cache-handles, r=at…
76cc08b 
…uron

std: Don't cache stdio handles on Windows

This alters the stdio code on Windows to always call `GetStdHandle` whenever the
stdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls `SetStdHandle` while it's running).

Closes rust-lang#40490
@alexcrichton alexcrichton mentioned this pull request Mar 27, 2017
Merged
bors added a commit that referenced this pull request Mar 27, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
32a2d73 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
bors added a commit that referenced this pull request Mar 28, 2017
@bors
Auto merge of #40867 - alexcrichton:rollup, r=alexcrichton
07a3429 
Rollup of 19 pull requests

- Successful merges: #40317, #40516, #40524, #40606, #40683, #40751, #40778, #40813, #40818, #40819, #40824, #40828, #40832, #40833, #40837, #40849, #40852, #40853, #40865
- Failed merges:
@bors bors merged commit 5ca8a73 into rust-lang:master Mar 29, 2017
@alexcrichton alexcrichton deleted the no-cache-handles branch April 4, 2017 23:08
@henninglive henninglive mentioned this pull request Jun 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @aturon @bors @arielb1