Rollup of 18 pull requests #40361
Closed
Rollup of 18 pull requests #40361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
This controls the value of the crt-static feature used when building the compiler and standard library. It can be set per target.
This avoids the possibility of a duplicate or conflicting crt-static command line option sent to rustc.
These options only exist for the special case of static cross-linking pure rust code for a musl-based target with a non-musl toolchain. In all other situations (dynamic linking, presence of a native or cross compiler) these objects will be automatically provided and linked by the toolchain.
To maintain existing behavior, it is disabled by default on all architectures except MIPS.
These were conditioned on architecture because traditionally MIPS was dynamically linked, while other arches used musl for static linking. Now that we support both methods of linking on all architectures, these special cases no longer make sense Add a comment explaining why copying startup files is always necessary
Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856)
I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
Support dynamically-linked and/or native musl targets These changes allow native compilation on musl-based distributions and the use of dynamic libraries on linux-musl targets. This is intended to remove limitations based on past assumptions about musl targets, while maintaining existing behavior by default. A minor related bugfix is included.
…frewsxcv add unstable book to the bookshelf r? @frewsxcv @GuillaumeGomez
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
Issue rust-lang#39688 - Help people find String::as_bytes() for UTF-8 Added in links for the inverse functions so people will know that as_bytes() is the inverse of from_utf8() and vice versa. ?r @steveklabnik
Fix description of closure coercion feature Thanks to @whitequark for pointing this out.
…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots:   
…alexcrichton rustbuild: expose LLVM_PARALLEL_LINK_JOBS This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
clarify docs for Args and ArgsOs The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
Fix text formatting in README There was a missing backtick in the README.
Remove extra space in test description (of a mod test)
Fix a typo in the docs
…turon README formatting in configure/make section Tiny change to render the `config.mk` correctly
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
…chton Update link to COMPILER_TESTS.md in CONTRIBUTING.md Link to compiler test documentation was broken after the file was moved by rust-lang#40086. This updates the link to the new location of the file.
Add missing urls in some macros doc r? @frewsxcv
Clarify handling of `src` in `ptr::write` Fixes rust-lang#39733.
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixes rust-lang#39201.
rustbuild: Assert directory creation succeeds I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
|
@bors r+ p=10 |
|
📌 Commit bfcee7b has been approved by |
|
Some changes occurred in HTML/CSS. |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
⌛ Testing commit bfcee7b with merge f22db34... |
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcinptr::write#40333, Document whystr.to_{lower,upper}casereturnString#40335, rustbuild: Assert directory creation succeeds #40337