Rollup of 17 pull requests #40080
Closed
Rollup of 17 pull requests #40080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Feb 24, 2017
frewsxcv
commented
- Successful merges: book: binary prefixed are defined by IEC and not in SI #39777, enable tools to use test runners programmatically #39815, Add Documentation for Custom Attributes and Error Reporting in Procedural Macros #39845, Additional docs for Vec, String, and slice trait impls #39886, Fix test caching on Windows/GNU #39892, add solaris sparcv9 support #39903, Properly display note/expected details #39905, Follow rename of mx_handle_wait Magenta syscalls #39914, transition borrowck to visit all **bodies** and not item-likes #39927, Fix indentation of error message #39940, Add missing urls and examples into Barrier structs #40010, Clarify thread::Builder::stack_size docs #40030, Update std::fmt module docs for landing of #33642. #40048, Update exception-safety.md #40050, Add missing urls in MutexGuard docs #40052, rustbuild: Retry downloads by default #40060, Correct another typo in procedural macros chapter of the Book. #40071
- Failed merges:
Binary prefixes (such as Gi for ‘gibi-’ in GiB) are defined by International Electrotechnical Commission (IEC) and not in the International System of Units (SI).
* Update bootstrap to recognize the cputype 'sparcv9' (used on Solaris) * Change to never use -fomit-frame-pointer on Solaris or for sparc * Adds rust target sparcv9-sun-solaris Fixes rust-lang#39901
The mx_handle_wait_* syscalls in Magenta were renamed to mx_object_wait. The syscall is used in the Magenta/Fuchsia implementation of std::process, to wait on child processes. In addition, this patch enables the use of the system provided libbacktrace library on Fuchsia targets. Symbolization is not yet working, but at least it allows printing hex addresses in a backtrace and makes building succeed when the backtrace feature is not disabled.
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
Otherwise the errors from borrowck come out in an unpredictable order.
This was specific to the old special-case handling of statics in borrowck.
Fix variable name typo
…richton add solaris sparcv9 support Fixes rust-lang#39901
Properly display note/expected details
Given a file
```rust
fn takes_cb(f: fn(i8)) {}
fn main() {
fn callback(x: i32) {}
takes_cb(callback)
}
```
output
```rust
error[E0308]: mismatched types
--> file2.rs:5:22
|
5 | takes_cb(callback)
| ^^^^^^^^ expected i8, found i32
|
= note: expected type `fn(i8)`
found type `fn(i32) {main::callback}`
```
Fix rust-lang#39343.
…chton Follow rename of mx_handle_wait Magenta syscalls The mx_handle_wait_* syscalls in Magenta were renamed to mx_object_wait. The syscall is used in the Magenta/Fuchsia implementation of std::process, to wait on child processes. In addition, this patch enables the use of the system provided libbacktrace library on Fuchsia targets. Symbolization is not yet working, but at least it allows printing hex addresses in a backtrace and makes building succeed when the backtrace feature is not disabled.
…k-2, r=eddyb transition borrowck to visit all **bodies** and not item-likes This is a better structure for incremental compilation and also more compatible with the eventual borrowck mir. It also fixes rust-lang#38520 as a drive-by fix. r? @eddyb
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
…sxcv Add missing urls and examples into Barrier structs r? @frewsxcv
Clarify thread::Builder::stack_size docs Add two pieces of information: * the size is in bytes * the actual stack size might be bigger. Also change the example to use a more realistic value of 32 kilobytes. r? @steveklabnik
…crichton Update std::fmt module docs for landing of rust-lang#33642. Since rust-lang#33642, it's no longer true that all references to a given format argument must use the same type. The docs don't seem to have been updated.
Update exception-safety.md Fix variable name typo
Add missing urls in MutexGuard docs r? @frewsxcv
rustbuild: Retry downloads by default Don't rely on curl's --retry, it appears to not work for some errors like SSL errors.
…s, r=GuillaumeGomez Correct another typo in procedural macros chapter of the Book. Another (and the only remaining) instance of the lets/let's mistake fixed in c8292fc / 36b00cf. r? @steveklabnik
|
@bors r+ p=15 |
|
📌 Commit c7a78c7 has been approved by |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
bors
added a commit
that referenced
this pull request
Feb 24, 2017
|
💔 Test failed - status-travis |
|
@bors retry |
|
⌛ Testing commit c7a78c7 with merge 3db316b... |
|
💔 Test failed - status-travis |
|
@bors retry |
|
⌛ Testing commit c7a78c7 with merge 350ac27... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.