Rollup of 7 pull requests #39769
Merged
Rollup of 7 pull requests #39769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 12, 2017
GuillaumeGomez
commented
- Successful merges: rustdoc: Show attributes on all item types #39654, Fixes #39661 #39662, Add the item type to the tooltip #39697, rustdoc: Only include a stability span if needed. #39740, Add tested item in the rustdoc --test output #39743, Sustitutes try! for ? in the Result documentation #39756, Improve grammar on field init docs #39760
- Failed merges:
Currently attributes are only shown for structs, unions and enums but they should be shown for all items. For example it is useful to know if a function is `#[no_mangle]`.
Clarified potential ambiguity.
…aumeGomez rustdoc: Show attributes on all item types Currently attributes are only shown for structs, unions and enums but they should be shown for all items. For example it is useful to know if a function is `#[no_mangle]`.
Fixes rust-lang#39661 Clarifies the potential ambiguity.
…umeGomez Add the item type to the tooltip See: https://users.rust-lang.org/t/seeking-opinions-from-colorblind-rustaceans-coloring-in-rustdoc-code-blocks
…, r=aturon rustdoc: Only include a stability span if needed. This patch gets rid of the empty stability boxes in docs by only including the span that creates it when the item actually has a stability class. Here are images of the issue on `std::process::Output`: Before: <img width="340" alt="before" src="https://cloud.githubusercontent.com/assets/122457/22853638/ff88d1b2-f010-11e6-90d6-bf3d10e2fffa.png"> After: <img width="333" alt="after" src="https://cloud.githubusercontent.com/assets/122457/22853639/06bfe7cc-f011-11e6-9892-f0ea2cc6ec90.png"> This is my first non-trivial patch to Rust, so I'm sure some of my approach is not idiomatic. Let me know how you'd like me to adjust!
… r=alexcrichton Add tested item in the rustdoc --test output r? @alexcrichton cc @SergioBenitez
…r=steveklabnik Sustitutes try! for ? in the Result documentation Hopefully newcomers will go strait to use `?`
…aumeGomez Improve grammar on field init docs
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10 |
|
📌 Commit 2f3dc95 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 12, 2017
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.