Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add 128-bit atomics" #39591

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

alexcrichton
Copy link
Member

This reverts commit 9903975.

Unfortunately 128-bit atomics have broken our nightly builds (#39590) and while we investigate I'm posting a temporary revert of the PR that added them. If we can figure out a solution though before this lands I'd be happy to close!

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 6, 2017

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Feb 6, 2017

📌 Commit bfa2642 has been approved by aturon

@brson
Copy link
Contributor

brson commented Feb 6, 2017

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 6, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 6, 2017

📌 Commit bfa2642 has been approved by brson

@bors
Copy link
Contributor

bors commented Feb 6, 2017

⌛ Testing commit bfa2642 with merge 30b398c...

@bors
Copy link
Contributor

bors commented Feb 6, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Feb 6, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 6, 2017

⌛ Testing commit bfa2642 with merge 7d13b23...

bors added a commit that referenced this pull request Feb 6, 2017
Revert "Add 128-bit atomics"

This reverts commit 9903975.

Unfortunately 128-bit atomics have broken our nightly builds (#39590) and while we investigate I'm posting a temporary revert of the PR that added them. If we can figure out a solution though before this lands I'd be happy to close!
@bors
Copy link
Contributor

bors commented Feb 6, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Feb 6, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 7, 2017

⌛ Testing commit bfa2642 with merge c49d102...

bors added a commit that referenced this pull request Feb 7, 2017
Revert "Add 128-bit atomics"

This reverts commit 9903975.

Unfortunately 128-bit atomics have broken our nightly builds (#39590) and while we investigate I'm posting a temporary revert of the PR that added them. If we can figure out a solution though before this lands I'd be happy to close!
@bors
Copy link
Contributor

bors commented Feb 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing c49d102 to master...

@bors bors merged commit bfa2642 into rust-lang:master Feb 7, 2017
@alexcrichton alexcrichton deleted the revert-128 branch February 11, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants