Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing urls for array docs #39276

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Add missing urls for array docs #39276

merged 1 commit into from
Jan 25, 2017

Conversation

GuillaumeGomez
Copy link
Member

frewsxcv
frewsxcv approved these changes Jan 24, 2017
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with my comment addressed

src/libstd/primitive_docs.rs
@@ -347,13 +330,31 @@ mod prim_pointer { }
/// ```
///
/// If the array has 32 or fewer elements (see above), you can also use the
/// array reference's `IntoIterator` implementation:
/// array reference's [`IntoIterator`] implementation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be:

[`IntoIterator`][intoiterator]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to keep the syntax I've put in here. So not sure if I should change it or not...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to change the item using [intoiterator] then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't intend to, however I can "reverse" the other urls if you prefer.

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 25, 2017

📌 Commit c8d1f32 has been approved by frewsxcv

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 25, 2017
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39276 - GuillaumeGomez:array_urls, r=frewsxcv
e305b99 
Add missing urls for array docs

r? @frewsxcv
bors added a commit that referenced this pull request Jan 25, 2017
@bors
Auto merge of #39296 - GuillaumeGomez:rollup, r=GuillaumeGomez
fc57e40 
Rollup of 6 pull requests

- Successful merges: #38930, #39212, #39251, #39267, #39276, #39278
- Failed merges:
@bors bors merged commit c8d1f32 into rust-lang:master Jan 25, 2017
@GuillaumeGomez GuillaumeGomez deleted the array_urls branch January 25, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @frewsxcv @bors