Update jemalloc to include various fixes for OSX 10.12 #39166
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit 265bd53 has been approved by |
|
@glandium out of curiosity was this done to fix bugs seen in the wild? In the sense that should we consider this for a backport? |
|
(backport to beta, that is) |
|
485c9210bbfa9d8fb98b5d3fbe33a7a7e2c4fec9 might be fixing issues in the wild, but I'm not entirely sure they actually exist as such. d5a6ab562890b93fec765c5d42884ce4fa5c61a0 + 62d87fce391b5a0a8a0ede05e6ee8b808cd57d88 do fix a non theoretical issue that happens in Thunderbird, where the address book manager calls into the system CoreData library, which then does something like malloc_zone_batch_malloc(malloc_default_zone(), ...) and that crashes with a branch to 0x0. It doesn't seem there are much more of those things in the wild, at least affecting Firefox or Thunderbird, from a quick look at crash reports. But, existing or future system libraries may do similar things at any time, and if it happens in a process where jemalloc is registered as zone allocator, crash follows. Now, for rust, this involves some crate using some system library through FFI that does those kinds of things. That's a pretty limited risk, and it's not going to be random crashes either: if someone tries to use CoreData from rust and use whatever it is in there that triggers the behavior we work around here, they would have crashed already on 10.12. OTOH, they may not have attributed it to rust... |
|
Ok, thanks for the explanation! |
Update jemalloc to include various fixes for OSX 10.12
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
No description provided.