travis: Pass --release-channel=nightly on deploy #39050
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Currently we're uploading a bunch of artifacts of the form: This should fix that and ensure they're named |
|
r? @brson |
|
@bors r+ From the comment in this patch it sounds like the test suite doesn't work with |
|
📌 Commit d74885d has been approved by |
|
@brson in general the test suite does work, it's the aux tests (mainly cargo test) that doesn't work because we don't want to vendor all those crates and all their dev deps too. |
alexcrichton
force-pushed
the
travis-nightly
branch
from
d74885d to
2363bd9
Compare
|
@bors: r=brson |
|
📌 Commit 2363bd9 has been approved by |
|
Doesn't it mean that a single nightly version would refer to multiple releases in the future? Everyday there's >1 merge and it seems the deploy builds are run on each of them. How do we deal with the versioning? |
|
@xen0n sort of, yeah. Our plan is to produce a full suite of release artifacts on every commit, but then we'll only promote one set of artifacts to the nightly each night. That way we can bisect any successful merge but we'll still only have one nightly every day |
|
So all the other artifacts that are not promoted are meant for the rustc devs only. I'm fine with this then. (BTW the android buildbot had gone down again... maybe restart everything like we've always been doing recently?) |
Apologies if this is the wrong place for this, but why do we want to restrain ourselves to only nightly publishes instead of after each PR merge? I don't really see a clear reason to do so, since nightly users in general probably want the latest rustc as it is (and as soon as possible). |
|
@Mark-Simulacrum So that we revamp things step by step? It's extra work to do, and personally I'd like to see the new release infra in place before proceeding to features like this. It won't hurt to have only one nightly per day, as we have all survived without the additional builds so far. |
|
Sure, I don't want to suggest doing that now, just wondering if there are factors other than "more work" involved. |
|
Yep my thoughts exactly. The goal is feature parity and then afterwards we can expand if need be. |
|
⌛ Testing commit 2363bd9 with merge a9a7456... |
|
💔 Test failed - status-travis |
alexcrichton
force-pushed
the
travis-nightly
branch
from
2363bd9 to
837120d
Compare
|
@bors: r=brson |
|
📌 Commit 837120d has been approved by |
|
⌛ Testing commit 837120d with merge 3bba9a0... |
|
💔 Test failed - status-travis |
alexcrichton
force-pushed
the
travis-nightly
branch
from
837120d to
570cba6
Compare
|
@bors: r=brson |
|
📌 Commit 570cba6 has been approved by |
|
⌛ Testing commit 570cba6 with merge f04d111... |
|
💔 Test failed - status-travis |
alexcrichton
force-pushed
the
travis-nightly
branch
from
570cba6 to
5c9bd11
Compare
|
@bors: r=brson |
|
📌 Commit 5c9bd11 has been approved by |
|
⌛ Testing commit 5c9bd11 with merge 3efaef9... |
|
💔 Test failed - status-travis |
This commit passes the `--release-channel=nightly` flag to all images which have the `DEPLOY` flag set. This means that we'll name artifacts and the compiler appropriately. This reworks a bit how arguments are passed, but for now doesn't change what's already being passed. Eventually we'll want to avoid enabling debug assertions and llvm assertions for *all* releases, but I figure we can tackle that a little bit more down the road.
alexcrichton
force-pushed
the
travis-nightly
branch
from
5c9bd11 to
0618580
Compare
|
@bors: r=brson |
|
📌 Commit 0618580 has been approved by |
travis: Pass --release-channel=nightly on deploy This commit passes the `--release-channel=nightly` flag to all images which have the `DEPLOY` flag set. This means that we'll name artifacts and the compiler appropriately. This reworks a bit how arguments are passed, but for now doesn't change what's already being passed. Eventually we'll want to avoid enabling debug assertions and llvm assertions for *all* releases, but I figure we can tackle that a little bit more down the road.
|
☀️ Test successful - status-appveyor, status-travis |
This commit passes the
--release-channel=nightlyflag to all images which havethe
DEPLOYflag set. This means that we'll name artifacts and the compilerappropriately.
This reworks a bit how arguments are passed, but for now doesn't change what's
already being passed. Eventually we'll want to avoid enabling debug assertions
and llvm assertions for all releases, but I figure we can tackle that a little
bit more down the road.