debuginfo: Ignore optimized enum tests for GDB versions that can't handle them. #39039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that only the gdbr tests should be ignored. It would be better if we directly annotated the tests, too (not the entire file) |
nrc
approved these changes
Jan 16, 2017
| @@ -94,6 +99,30 @@ impl EarlyProps { | |||
| } | |||
| } | |||
|
|
|||
| fn extract_gdb_version_range(line: &str) -> (u32, u32) { | |||
There was a problem hiding this comment.
Could you add a comment explaining the return type please?
| .collect::<Vec<&str>>(); | ||
|
|
||
| match range_components.len() { | ||
| 0 => panic!(ERROR_MESSAGE), |
| .split(' ') | ||
| .last() | ||
| .expect("Malformed GDB version directive"); | ||
| let min_version = extract_gdb_version_range(line); |
There was a problem hiding this comment.
I think the name is misleading because it is both the min and max version? Rather, than renaming, using a destructuring let rather than tuple indexing would probably be more readable.
| actual_version < extract_gdb_version(min_version).unwrap() | ||
| actual_version < min_version.0 | ||
| } else if line.contains("ignore-gdb-version") { | ||
| let version_range = extract_gdb_version_range(line); |
There was a problem hiding this comment.
Again, I'd prefer to destructure here.
|
@bors r=nrc Thanks for the review, I think the comments are all addressed now. |
|
📌 Commit 30ba990 has been approved by |
|
@bors rollup |
Sorry, I didn't find the time to implement that. Maybe I'll come back to this later but feel free to implement it (e.g. by adding a "ignore-gdbr-in-version-range" directive). |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 19, 2017
…, r=nrc debuginfo: Ignore optimized enum tests for GDB versions that can't handle them. Fixes rust-lang#38948. r? @nrc cc @Manishearth
This was referenced Feb 4, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38948.
r? @nrc
cc @Manishearth