rustbuild: Fix a few rebuilding issues #38809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what the comment says, we actually need to do this. We're not cleaning out the stage0 compiler's sysroot, but rather just our own sysroot that we assembled previously.
Recent versions of Cargo lift less output up into the "main" directory, so let's look more inside the `deps` folder for changes to propagate differences. Closes rust-lang#38744 Closes rust-lang#38746
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 3ab778b has been approved by |
|
@bors: p=1 |
bors
added a commit
that referenced
this pull request
Jan 4, 2017
rustbuild: Fix a few rebuilding issues Did a bit of investigation and found a few small unrelated issues, but this should help clean up a lot of errors we've been seeing locally.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a bit of investigation and found a few small unrelated issues, but this should help clean up a lot of errors we've been seeing locally.