Detect double reference when applying binary op #38617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
pnkfelix
changed the title
|
Thanks also to @rkruppe for providing the lion's share of the review effort here. |
|
@bors r=pnkfelix |
|
📌 Commit 98218b3 has been approved by |
|
@bors r- Travis failed and it looks legit (but trivial to fix) |
```rust
let vr = v.iter().filter(|x| {
x % 2 == 0
});
```
will now yield the following compiler output:
```bash
ERROR binary operation `%` cannot be applied to type `&&_`
NOTE this is a reference of a reference to a type that `%` can be applied to,
you need to dereference this variable once for this operation to work
NOTE an implementation of `std::ops::Rem` might be missing for `&&_`
```
The first NOTE is new.
Bug rust-lang#33877
pnkfelix
force-pushed
the
double-reference
branch
from
98218b3
to
a5e1ff6
Compare
… deref. drive-by: fix merge conflict; fix test expected error output post rebase.
pnkfelix
force-pushed
the
double-reference
branch
from
a5e1ff6
to
b8669df
Compare
|
@bors r=pnkfelix |
|
📌 Commit 98218b3 has been approved by |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 4, 2017
Detect double reference when applying binary op
``` rust
let vr = v.iter().filter(|x| {
x % 2 == 0
});
```
will now yield the following compiler output:
``` bash
ERROR binary operation `%` cannot be applied to type `&&_`
NOTE this is a reference of a reference to a type that `%` can be applied to,
you need to dereference this variable once for this operation to work
NOTE an implementation of `std::ops::Rem` might be missing for `&&_`
```
The first NOTE is new.
Fix rust-lang#33877
----
Thanks to @estebank for providing the original PR rust-lang#34420 (of which this is a tweaked rebase).
|
💡 This pull request was already approved, no need to approve it again.
|
|
🙀 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
🙀 |
|
@bors r- |
|
@bors r+ rollup |
|
📌 Commit 98218b3 has been approved by |
|
@bors r- |
|
🙀 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 28, 2017
Detect double reference when applying binary op
``` rust
let vr = v.iter().filter(|x| {
x % 2 == 0
});
```
will now yield the following compiler output:
``` bash
ERROR binary operation `%` cannot be applied to type `&&_`
NOTE this is a reference of a reference to a type that `%` can be applied to,
you need to dereference this variable once for this operation to work
NOTE an implementation of `std::ops::Rem` might be missing for `&&_`
```
The first NOTE is new.
Fix rust-lang#33877
----
Thanks to @estebank for providing the original PR rust-lang#34420 (of which this is a tweaked rebase).
bors
added a commit
that referenced
this pull request
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will now yield the following compiler output:
The first NOTE is new.
Fix #33877
Thanks to @estebank for providing the original PR #34420 (of which this is a tweaked rebase).