Update book for rustup #38122
Update book for rustup #38122
Conversation
|
/cc @rust-lang/docs @carols10cents |
| Installing on Windows is nearly as easy: download and run | ||
| [rustup-init.exe]. It will run the installation in a console and | ||
| present the above message on success. For other installation options | ||
| and information, visit the [install] page of the Rust website. |
There was a problem hiding this comment.
For other installation options and information, visit the [install] page of the Rust website.
Nit: It might make sense to put this on a different line than the Windows instructions.
|
|
||
| If we're on Linux or a Mac, all we need to do is open a terminal and type this: | ||
| All we need to do on On Unix systems like Linux and macOS is open a |
There was a problem hiding this comment.
I know the tense didn't change with this PR, but maybe this "we" should be a "you'll"?
There was a problem hiding this comment.
Also, "On" doesn't need to be capitalized.
| shells, and bugs in installation, you may need to restart your shell, | ||
| log out of the system, or configure `PATH` manually. If necessary, | ||
| configure your `PATH` variable as appropriate for your operating | ||
| environment. |
There was a problem hiding this comment.
This last sentence doesn't seem necessary to me, but I don't feel strongly.
There was a problem hiding this comment.
Yeah, it could be combined with the previous sentence imo:
Due to differences in operating systems, command shells, and bugs in installation, you may need to restart your shell, log out of the system, or configure
PATHmanually as appropriate for your operating environment.
|
in general r+, I agree with the suggestions @frewsxcv made though! (also i don't have r) |
|
Made all suggested edits. Thanks for the reviews @frewsxcv and @carols10cents . |
| log out of the system, or configure `PATH` manually. If necessary, | ||
| configure your `PATH` variable as appropriate for your operating | ||
| environment. | ||
| log out of the system, or configure PATH manually as appropriate for |
| ``` | ||
|
|
||
| This will download a script, and start the installation. If it all goes well, | ||
| you’ll see this appear: | ||
| That will download a script, and start the installation. If it all |
| This will download a script, and start the installation. If it all goes well, | ||
| you’ll see this appear: | ||
| That will download a script, and start the installation. If it all | ||
| goes well, you’ll see this appear: |
There was a problem hiding this comment.
"If everything goes well"?
| ``` | ||
|
|
||
| From here, press `y` for ‘yes’, and then follow the rest of the prompts. | ||
| Installing on Windows is nearly as easy: download and run | ||
| [rustup-init.exe]. It will run the installation in a console and |
There was a problem hiding this comment.
I don't like the "run" repetition. You could maybe replace it with "It will start the installation"?
|
Made all suggested edits again. Thanks for the review @GuillaumeGomez. |
|
I don't see any difference @brson. Did you forget to push? :p |
|
I did forget to push. |
|
@bors r=steveklabnik |
|
📌 Commit 7628582 has been approved by |
|
Rebased. @bors r=steveklabnik |
|
📌 Commit 7550e32 has been approved by |
brson
added
beta-nominated
Update book for rustup Supersedes #37934 Don't land yet. Needs coordination with rust-lang/prev.rust-lang.org#621 Fixes #35653 r? @steveklabnik
Supersedes #37934
Don't land yet. Needs coordination with rust-lang/prev.rust-lang.org#621
Fixes #35653
r? @steveklabnik