Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literal 5 instead of five in book section 4.1 #37960

Merged
merged 1 commit into from
Nov 26, 2016
Merged

Use literal 5 instead of five in book section 4.1 #37960

merged 1 commit into from
Nov 26, 2016

Conversation

samestep
Copy link
Contributor

The other two code snippets in this sentence are valid code, so it makes more sense to use the literal 5 rather than the invalid symbol five.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member

frewsxcv commented Nov 23, 2016

I agree, it should either be "5" or "five". It seems strange for it to be "five". Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 23, 2016

📌 Commit 49c6b3c has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Nov 23, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Nov 23, 2016

📌 Commit 49c6b3c has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Nov 26, 2016

⌛ Testing commit 49c6b3c with merge d64b703...

bors added a commit that referenced this pull request Nov 26, 2016
Use literal 5 instead of five in book section 4.1

The other two code snippets in this sentence are valid code, so it makes more sense to use the literal `5` rather than the invalid symbol `five`.
@bors bors merged commit 49c6b3c into rust-lang:master Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants