Rollup of 8 pull requests #37896
Merged
Rollup of 8 pull requests #37896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Nov 20, 2016
GuillaumeGomez
commented
- Successful merges: Update E0088 to new error format #37835, Fix grammar error in lifetimes.md #37840, ICH: Add regression tests for various kinds of loops. #37841, Don't clone in UnificationTable::probe(). #37848, reference: fix duplicate bullet points in feature list #37876, Add missing examples in SocketAddr #37880, rustdoc: Remove unnecessary stability versions #37881, Optimise Chars::last() #37882
- Failed merges:
This speeds up compilation of rustc-benchmarks/inflate-0.1.0 by 1%.
For some reason only on enum and macro pages, the stability version is rendered after the summary unlike all other pages. As it is already displayed at the top of the page for all items, this removes it for consistency and to prevent it from overlapping the summary text.
The default implementation of last() goes through the entire iterator but that's not needed here.
The default implementation of last() goes through the entire iterator but that's not needed here.
Update E0088 to new error format Fixes rust-lang#35226 which is part of rust-lang#35233. Is based on rust-lang#36208 from @yossi-k. r? @jonathandturner
Fix grammar error in lifetimes.md
…nikomatsakis ICH: Add regression tests for various kinds of loops. r? @nikomatsakis
… r=arielb1 Don't clone in UnificationTable::probe(). This speeds up compilation of rustc-benchmarks/inflate-0.1.0 by 1%.
reference: fix duplicate bullet points in feature list
…sxcv Add missing examples in SocketAddr r? @frewsxcv
…alexcrichton rustdoc: Remove unnecessary stability versions For some reason only on enum and macro pages, the stability version is rendered after the summary unlike all other pages. As it is already displayed at the top of the page for all items, this removes it for consistency and to prevent it from overlapping the summary text. Fixes rust-lang#36093
Optimise Chars::last() The default implementation of last() goes through the entire iterator but that's not needed here.
|
@bors: r+ p=1 |
|
📌 Commit b0354fe has been approved by |
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
Travis has an error. |
|
Travis is weird now. Only one test failed. |
|
On each pull request, Travis only builds one of the environments: https://github.com/rust-lang/rust/blob/master/.travis.yml#L24 Marked by |
|
Well, it seems that LLVM didn't build, so... |
|
I think |
bors
added a commit
that referenced
this pull request
Nov 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.