Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a borrow surviving too long (fixes #37686) #37687

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Nov 10, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Nov 10, 2016

@bors r+ p=1 (unbreaks the nightly for Servo)

@bors
Copy link
Contributor

bors commented Nov 10, 2016

📌 Commit cc13f90 has been approved by eddyb

@est31
Copy link
Member

est31 commented Nov 10, 2016

Maybe a regression test would be useful?

@eddyb
Copy link
Member

eddyb commented Nov 10, 2016

Oh, right, forgot about that. I gave a minimal testcase, that should be used. @bors r-

@nox
Copy link
Contributor Author

nox commented Nov 10, 2016

Where does it go?

@sfackler
Copy link
Member

src/test/run-pass

@eddyb
Copy link
Member

eddyb commented Nov 10, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2016

📌 Commit 84239df has been approved by eddyb

@bors
Copy link
Contributor

bors commented Nov 10, 2016

⌛ Testing commit 84239df with merge bc1cc1d...

bors added a commit that referenced this pull request Nov 10, 2016
Work around a borrow surviving too long (fixes #37686)
@bors bors merged commit 84239df into rust-lang:master Nov 10, 2016
@nox nox deleted the patch-1 branch November 10, 2016 22:21
@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 3, 2016
@arielb1
Copy link
Contributor

arielb1 commented Dec 3, 2016

This is a stable->beta regression. It needs to be applied to 1.14.0.

@brson brson added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 10, 2016
@brson
Copy link
Contributor

brson commented Dec 10, 2016

Please review for backport.

@eddyb
Copy link
Member

eddyb commented Dec 10, 2016

Tiny straight-forward bugfix. @rust-lang/compiler hope you don't mind.

@eddyb eddyb added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Dec 10, 2016
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 15, 2016
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants