Rollup of 10 pull requests #37337
Merged
Rollup of 10 pull requests #37337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Oct 21, 2016
GuillaumeGomez
commented
- Successful merges: Add missing urls on Vec docs #37043, run rustfmt on bootstrap/bin folder #37209, run rustfmt on various folders #37211, Run rustfmt on libcore/prelude folder #37219, Add error explaination for E0182, E0230 and E0399 #37244, Apply rustfmt on liballoc folder #37253, run rustfmt on graph folder #37286, test - Add missing ! to crate_type/crate_id attributes #37297, TRPL: guessing game: minor clarification #37309, doc: a more simple description of Iterator::nth #37314
- Failed merges:
Add missing urls on Vec docs r? @steveklabnik
run rustfmt on bootstrap/bin folder
run rustfmt on various folders
Run rustfmt on libcore/prelude folder
…r=GuillaumeGomez Add error explaination for E0182, E0230 and E0399 This PR adds some error descriptions requested in issue rust-lang#32777. r? @GuillaumeGomez Specifically this adds descriptions for E0182 - unexpected binding of associated item in expression path E0230 - missing type parameter from on_unimplemented description E0399 - overriding a trait type without re-implementing default methods
Apply rustfmt on liballoc folder
run rustfmt on graph folder
…r=eddyb test - Add missing ! to crate_type/crate_id attributes Fix some useless attributes in a test dependency.
…illaumeGomez TRPL: guessing game: minor clarification The original text is correct and exact, but might confuse a non-English speaker (at least I was confused), so I made it a bit more plain (see rust-lang#37307). I know minor wording changes like these are affected by personal style, so I'd understand if you don't find this useful. r? @steveklabnik
doc: a more simple description of Iterator::nth
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 1c2d223 has been approved by |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.