Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some mistakes in HRTB docs #37255

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Fix some mistakes in HRTB docs #37255

merged 1 commit into from
Nov 6, 2016

Conversation

mbrubeck
Copy link
Contributor

The example code for higher-ranked trait bounds on closures had an unnecessary mut which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the muts and fixed the text to better describe the actual error for the failing example.

Thanks to csd_ on IRC for pointing out these problems!

r? @steveklabnik

The example code for higher-ranked trait bounds on closures had an
unnecessary `mut` which was confusing, and the text referred to an
mutable reference which does not exist in the code (and isn't needed).
Removed the `mut`s and fixed the text to better describe the actual
error for the failing example.
@steveklabnik
Copy link
Member

@bors: delegate=kmcallister

I think this looks good. What do you think, @kmcallister ?

@bors
Copy link
Contributor

bors commented Oct 24, 2016

✌️ @kmcallister can now approve this pull request

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Nov 3, 2016

📌 Commit f89ba5d has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Nov 3, 2016

⌛ Testing commit f89ba5d with merge 6c17a05...

@bors
Copy link
Contributor

bors commented Nov 3, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@steveklabnik
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 3, 2016

⌛ Testing commit f89ba5d with merge bacff0a...

@bors
Copy link
Contributor

bors commented Nov 3, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 4, 2016
Fix some mistakes in HRTB docs

The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed).  Removed the `mut`s and fixed the text to better describe the actual error for the failing example.

Thanks to csd_ on IRC for pointing out these problems!

r? @steveklabnik
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2016
Fix some mistakes in HRTB docs

The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed).  Removed the `mut`s and fixed the text to better describe the actual error for the failing example.

Thanks to csd_ on IRC for pointing out these problems!

r? @steveklabnik
bors added a commit that referenced this pull request Nov 5, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 5, 2016
Fix some mistakes in HRTB docs

The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed).  Removed the `mut`s and fixed the text to better describe the actual error for the failing example.

Thanks to csd_ on IRC for pointing out these problems!

r? @steveklabnik
bors added a commit that referenced this pull request Nov 6, 2016
@bors bors merged commit f89ba5d into rust-lang:master Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants