Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two functions to check type of SockAddr #36762

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Add two functions to check type of SockAddr #36762

merged 1 commit into from
Oct 12, 2016

Conversation

achanda
Copy link
Contributor

@achanda achanda commented Sep 27, 2016

These can be used to determine the type of the underlying IP
address

r? @alexcrichton

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 27, 2016
@alexcrichton
Copy link
Member

Thanks! I might prefer to call this is_ipv4 or is_ipv6 to be clear what the "v" is as well, but otherwise looks reasonable to me.

cc @rust-lang/libs

@achanda
Copy link
Contributor Author

achanda commented Sep 27, 2016

Updated both!

@aturon
Copy link
Member

aturon commented Sep 27, 2016

I'm 👍 on these additions.

@achanda
Copy link
Contributor Author

achanda commented Sep 29, 2016

And this one too!

@alexcrichton
Copy link
Member

@rfcbot fcp merge

We'll want to file a tracking issue for these APIs as well, but that can happen just before merging

@rfcbot
Copy link

rfcbot commented Oct 3, 2016 •
edited
Loading

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

@achanda
Add two functions to check type of SockAddr
d9e6430 
These can be used to determine the type of the underlying IP
address
@achanda achanda mentioned this pull request Oct 4, 2016
Closed
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 10, 2016

📌 Commit d9e6430 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 11, 2016

⌛ Testing commit d9e6430 with merge 17c1d39...

@bors
Copy link
Contributor

bors commented Oct 11, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Oct 11, 2016 at 1:17 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5858

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36762 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95P9ZDemSzcLge68n98Oav_oR64peks5qy0YBgaJpZM4KHIcu
.

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 11, 2016
Rollup merge of rust-lang#36762 - achanda:sockaddr_type, r=alexcrichton
6f81f2f 
Add two functions to check type of SockAddr

These can be used to determine the type of the underlying IP
address

r? @alexcrichton
@sophiajt sophiajt mentioned this pull request Oct 11, 2016
Closed
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37093 - jonathandturner:rollup, r=jonathandturner
ccb8b3e 
Rollup of 10 pull requests

- Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067
- Failed merges:
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 12, 2016
@alexcrichton
Rollup merge of rust-lang#36762 - achanda:sockaddr_type, r=alexcrichton
76fb6e7 
Add two functions to check type of SockAddr

These can be used to determine the type of the underlying IP
address

r? @alexcrichton
@alexcrichton alexcrichton mentioned this pull request Oct 12, 2016
Merged
@bors
Copy link
Contributor

bors commented Oct 12, 2016

⌛ Testing commit d9e6430 with merge 9cb0136...

bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #36762 - achanda:sockaddr_type, r=alexcrichton
9cb0136 
Add two functions to check type of SockAddr

These can be used to determine the type of the underlying IP
address

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 12, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 9cb0136 to master...

bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37118 - alexcrichton:rollup, r=alexcrichton
d34318d 
Rollup of 17 pull requests

- Successful merges: #36762, #36831, #36973, #36991, #36995, #37023, #37049, #37050, #37056, #37064, #37066, #37067, #37084, #37089, #37091, #37092, #37110
- Failed merges:
@bors bors merged commit d9e6430 into rust-lang:master Oct 12, 2016
@achanda achanda deleted the sockaddr_type branch October 12, 2016 21:43
@rfcbot
Copy link

rfcbot commented Oct 17, 2016

@alexcrichton proposal cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@achanda @alexcrichton @aturon @rfcbot @bors