Fix a variety of minor issues #36559
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -2913,7 +2913,7 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { | |||
|
|
|||
| /// See `ParameterEnvironment` struct def'n for details. | |||
| /// If you were using `free_id: NodeId`, you might try `self.region_maps.item_extent(free_id)` | |||
| /// for the `free_id_outlive` parameter. (But note that that is not always quite right.) | |||
| /// for the `free_id_outlive` parameter. (But note that is not always quite right.) | |||
There was a problem hiding this comment.
I think the "that that" was intentional here, at least it reads better to me. If you want to get rid of the double "that", maybe "note that this is not" would be work.
|
ping? |
| @@ -459,7 +459,8 @@ a { | |||
| .content .search-results td:first-child { padding-right: 0; } | |||
| .content .search-results td:first-child a { padding-right: 10px; } | |||
|
|
|||
| tr.result span.primitive::after { content: ' (primitive type)'; font-style: italic; color: black} | |||
| tr.result span.primitive::after { content: ' (primitive type)'; font-style: italic; color: black; | |||
| } | |||
There was a problem hiding this comment.
any reason for the newline here? seems surprising
There was a problem hiding this comment.
can't confirm right now but I suspect this was an automatic change based on line length. It can be reverted.
|
@bors r+ rollup cc @steveklabnik maybe you want to eyeball the CSS but it seems fine to me |
|
📌 Commit 0c252ff has been approved by |
|
@grimreaper sorry the for delay, been traveling :) |
Fix a variety of minor issues CSS: - use integer values for font-size in CSS - use correct ordering of @import - "invisible" isn't a tag - presume its a class - "border-color" defines the complete border python: - use "not" instead of == "[]" for python - prefer triple quoted docstrings - prefer static functions where possible - prefer modern style classes where possible - remove semicolons; global: - remove duplicated words words
CSS:
python:
global: