Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicate where to copy config.toml.example #36231

Merged
merged 2 commits into from
Sep 4, 2016
Merged

Conversation

durka
Copy link
Contributor

@durka durka commented Sep 2, 2016

@alexcrichton
Copy link
Member

Hm perhaps this could say "copy this file to the object directory" or something like that? I think we need to be a bit more specific than "../config.toml"

@durka
Copy link
Contributor Author

durka commented Sep 3, 2016

Personally I wouldn't know where the "object directory" is. Or did that autocorrect from "parent directory"?

@durka
Copy link
Contributor Author

durka commented Sep 3, 2016

The paragraph below makes it sound like you could run bootstrap.py from any directory and it would look for config.toml in the CWD. Is that so?

@TimNN
Copy link
Contributor

TimNN commented Sep 3, 2016

@durka Yes

@alexcrichton
Copy link
Member

alexcrichton commented Sep 3, 2016

Ah yeah "object directory" == "cwd of the invocation of bootstrap.py"

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 3, 2016

📌 Commit a34485f has been approved by alexcrichton

@durka
Copy link
Contributor Author

durka commented Sep 3, 2016

@alexcrichton some other tools (e.g. rustfmt) look up the directory tree if config.toml doesn't exist, so if you had several rust builds in a dir you could put a global config.toml above them or something like that. Would that be desirable behavior for rustbuild?

@alexcrichton
Copy link
Member

Hm perhaps! I haven't thought too much about it but seems reasonable. Dealing with conflicting configuration though might be kinda unfortunate.

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 4, 2016
bors added a commit that referenced this pull request Sep 4, 2016
Rollup of 7 pull requests

- Successful merges: #36070, #36132, #36200, #36212, #36225, #36231, #36234
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 4, 2016
bors added a commit that referenced this pull request Sep 4, 2016
Rollup of 7 pull requests

- Successful merges: #36070, #36132, #36200, #36212, #36225, #36231, #36234
- Failed merges:
@bors bors merged commit a34485f into rust-lang:master Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants