Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0318 to new format #36079

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Update E0318 to new format #36079

merged 1 commit into from
Aug 31, 2016

Conversation

acrrd
Copy link
Contributor

@acrrd acrrd commented Aug 28, 2016

Fixes #35322.
Part of #35233.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

//~^ ERROR E0318

impl Copy for .. {} //~ ERROR E0318
//~^^^^ ERROR `Copy` trait not defined in this crate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so much "^^^^^"?

@acrrd
Copy link
Contributor Author

acrrd commented Aug 29, 2016

It was to underline the same part that the error do.
I removed them.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 29, 2016

📌 Commit ef3a34a has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Copy link
Member

@bors: r-

Error:

---- [compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs stdout ----

error: C:/bot/slave/auto-win-gnu-32-opt-rustbuild/build/src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs:13: expected error not found: `Copy` trait not defined in this crate

error: 0 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: PATH="C:\bot\slave\..."
not found errors (from test file): [
    Error {
        line_num: 13,
        kind: Some(
            Error
        ),
        msg: "`Copy` trait not defined in this crate"
    }
]

thread '[compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs' panicked at 'explicit panic', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\tools\compiletest\src\runtest.rs:1084


failures:
    [compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs

test result: FAILED. 2524 passed; 1 failed; 12 ignored; 0 measured

@acrrd
Copy link
Contributor Author

acrrd commented Aug 30, 2016

Sorry about that, I pushed the fix and run the correct test this time.

@GuillaumeGomez
Copy link
Member

Have you tested it? I wonder if it was waiting for a note or an error. It's not very clear...

@acrrd
Copy link
Contributor Author

acrrd commented Aug 30, 2016

Before I put an ERROR in the test, now I put NOTE and works.

@GuillaumeGomez
Copy link
Member

Fine by me then. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 31, 2016

📌 Commit bdfcd78 has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
bors added a commit that referenced this pull request Aug 31, 2016
@bors bors merged commit bdfcd78 into rust-lang:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants