Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to Self in traits chapter (book) #35891

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Conversation

munyari
Copy link
Contributor

@munyari munyari commented Aug 22, 2016

Addresses #31891

"r? @steveklabnik

@munyari munyari changed the title Add reference to in traits chapter (book) Add reference to Self in traits chapter (book) Aug 22, 2016
@munyari
Copy link
Contributor Author

munyari commented Aug 22, 2016

So I just learned that I can't put the backticks in commit messages... Somewhere between my editor and github Self got lost.

@GuillaumeGomez
Copy link
Member

failures:

---- _2 stdout ----
    error[E0412]: type name `Circle` is undefined or not in scope
 --> <anon>:8:18
  |
8 | impl HasArea for Circle {
  |                  ^^^^^^ undefined or not in scope
  |
  = help: no candidates by the name of `Circle` found in your project; maybe you misspelled the name or forgot to import an external crate?

error: aborting due to previous error(s)

thread '_2' panicked at 'Box<Any>', src/librustc/session/mod.rs:167

@munyari
Copy link
Contributor Author

munyari commented Aug 22, 2016

Hey @GuillaumeGomez, how can I run doc tests for the book only?

@steveklabnik
Copy link
Member

@munyari when I do it, I just call rustdoc on the markdown file directly.

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2016

📌 Commit 3da5f93 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Add reference to `Self` in traits chapter (book)

Addresses rust-lang#31891

"r? @steveklabnik
bors added a commit that referenced this pull request Aug 22, 2016
@bors bors merged commit 3da5f93 into rust-lang:master Aug 23, 2016
@munyari munyari deleted the book branch August 23, 2016 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants