Fix soundness bug described in #29859 #35745

jroesch · 2016-08-17T05:57:02Z

This is an attempt at fixing the problems described in #29859 based on an IRC conversation between @nikomatsakis and I today. I'm waiting on a full build to come back, otherwise both tests trigger the correct error.

rust-highfive · 2016-08-17T05:57:14Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2016-08-17T09:09:12Z

☔ The latest upstream changes (presumably #35605) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-08-17T12:16:49Z

src/librustc_typeck/check/wfcheck.rs

+    {
+        let predicates = self.tcx().lookup_predicates(trait_def_id);
+
+        // If we must exclude the Self : Trait predicate contained by all


Nit: s/If we/We/

nikomatsakis · 2016-08-18T18:32:39Z

src/librustc_typeck/check/wfcheck.rs

+        } else if has_predicates {
+            span_err!(self.tcx().sess, span, E0565,
+                "traits with auto impls (`e.g. unsafe impl \
+                    Trait for ..`) can not have predicates")


Nit: s/can not/cannot/, also let's make if impl Trait for .. and not unsafe impl Trait

nikomatsakis · 2016-08-18T19:04:26Z

@bors r+

bors · 2016-08-18T19:04:27Z

📌 Commit 26c6439 has been approved by nikomatsakis

jroesch · 2016-08-18T19:50:57Z

@bors r=nikomatsakis

bors · 2016-08-18T19:50:58Z

📌 Commit feff760 has been approved by nikomatsakis

jroesch · 2016-08-19T00:32:14Z

@bors r=nikomatsakis

alexcrichton · 2016-08-20T20:07:06Z

@bors: retry force clean

@bors is ... stuck?

jroesch · 2016-08-22T06:20:54Z

Thanks @alexcrichton, not really sure why it wasn't building, been moving apartments this weekend so haven't had any time to chase it down.

nikomatsakis · 2016-08-22T21:59:00Z

Huh. What is happening with bors here. :)

nikomatsakis · 2016-08-22T21:59:03Z

@bors r-

nikomatsakis · 2016-08-22T21:59:08Z

@bors r+

bors · 2016-08-22T21:59:09Z

📌 Commit fad75e6 has been approved by nikomatsakis

bors · 2016-08-22T22:27:49Z

⌛ Testing commit fad75e6 with merge 71b0f61...

bors · 2016-08-22T23:59:28Z

💔 Test failed - auto-mac-64-opt

jroesch · 2016-08-29T09:41:26Z

@bors r-

jroesch · 2016-08-29T09:54:18Z

@bors r=nikomatsakis

bors · 2016-08-29T09:54:19Z

📌 Commit dba5cbe has been approved by nikomatsakis

bors · 2016-08-29T09:54:21Z

⌛ Testing commit dba5cbe with merge b58dddd...

@nikomatsakis

Fix soundness bug described in #29859 This is an attempt at fixing the problems described in #29859 based on an IRC conversation between @nikomatsakis and I today. I'm waiting on a full build to come back, otherwise both tests trigger the correct error.

bors · 2016-08-29T10:01:49Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-08-29T16:55:57Z

@bors retry

bors · 2016-09-01T07:57:00Z

⌛ Testing commit dba5cbe with merge e98a1a4...

bors · 2016-09-01T09:53:27Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

Fixes rust-lang#29859

nikomatsakis · 2016-09-03T12:07:01Z

Travis failure:

rustc: x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd
LD_LIBRARY_PATH=/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH x86_64-unknown-linux-gnu/stage0/bin/tidy /build/src
/build/src/test/compile-fail/typeck-auto-trait-no-supertraits.rs:26: trailing whitespace
/build/src/test/compile-fail/typeck-auto-trait-no-supertraits.rs:38: trailing whitespace
/build/src/test/compile-fail/typeck-auto-trait-no-supertraits-2.rs:14: trailing whitespace
duplicate error code: 565
/build/src/libsyntax/diagnostic_list.rs:164: E0565: r##"
/build/src/librustc_typeck/diagnostics.rs:4075:     E0565, // auto-traits can not have predicates,
duplicate error code: 566
/build/src/librustc/diagnostics.rs:1807:     E0566  // conflicting representation hints
/build/src/librustc_typeck/diagnostics.rs:4076:     E0566, // auto traits can not have type parameters
thread 'main' panicked at 'some tidy checks failed', /build/src/tools/tidy/src/main.rs:53
note: Run with `RUST_BACKTRACE=1` for a backtrace.
make: *** [tidy] Error 101
/build/mk/tests.mk:247: recipe for target 'tidy' failed

nikomatsakis · 2016-09-08T11:52:01Z

@bors r+

bors · 2016-09-08T11:52:02Z

📌 Commit a254282 has been approved by nikomatsakis

bors · 2016-09-08T11:56:50Z

⌛ Testing commit a254282 with merge 384969e...

bors · 2016-09-08T14:20:50Z

💔 Test failed - auto-linux-32-nopt-t

alexcrichton · 2016-09-08T14:55:37Z

@bors: retry

Spurious incremental mkdir error #36238

On Thu, Sep 8, 2016 at 7:20 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-32-nopt-t
https://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/10455

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35745 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Nb03OZhOLd0TnBejjOD7bE3aXOzks5qoBnIgaJpZM4JmHk0
.

bors · 2016-09-08T17:40:31Z

⌛ Testing commit a254282 with merge ea45edf...

@nikomatsakis

Fix soundness bug described in #29859 This is an attempt at fixing the problems described in #29859 based on an IRC conversation between @nikomatsakis and I today. I'm waiting on a full build to come back, otherwise both tests trigger the correct error.

bors · 2016-09-08T20:56:51Z

rust-highfive assigned nikomatsakis Aug 17, 2016

nikomatsakis reviewed Aug 17, 2016
View reviewed changes

jroesch force-pushed the soundness-fix-29859 branch from 87ccbb9 to da2451e Compare August 18, 2016 01:17

nikomatsakis reviewed Aug 18, 2016
View reviewed changes

jroesch force-pushed the soundness-fix-29859 branch from 6da7b17 to feff760 Compare August 18, 2016 19:49

jroesch force-pushed the soundness-fix-29859 branch from feff760 to fad75e6 Compare August 19, 2016 00:31

jroesch force-pushed the soundness-fix-29859 branch from 01d509e to dba5cbe Compare August 29, 2016 09:40

jroesch added 6 commits September 2, 2016 11:58

Add tests for rust-lang#29859

f18c990

Reject certain auto trait declarations

352fac9

Fixes rust-lang#29859

Address feedback, and remove invalid tests

90d1a53

Address feedback on secondary changes

ed5843b

Forget to update tests to use new error message

6eb06e6

Remove illegal bound from doc test

9510add

jroesch force-pushed the soundness-fix-29859 branch from dba5cbe to 9510add Compare September 2, 2016 18:58

Fix duplicate error code

a254282

bors merged commit a254282 into rust-lang:master Sep 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix soundness bug described in #29859 #35745

Fix soundness bug described in #29859 #35745

jroesch commented Aug 17, 2016 •

edited

Loading

rust-highfive commented Aug 17, 2016

bors commented Aug 17, 2016

nikomatsakis Aug 17, 2016

nikomatsakis Aug 18, 2016

nikomatsakis commented Aug 18, 2016

bors commented Aug 18, 2016

jroesch commented Aug 18, 2016

bors commented Aug 18, 2016

jroesch commented Aug 19, 2016 •

edited

Loading

alexcrichton commented Aug 20, 2016

jroesch commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

bors commented Aug 22, 2016

bors commented Aug 22, 2016

bors commented Aug 22, 2016

jroesch commented Aug 29, 2016

jroesch commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

arielb1 commented Aug 29, 2016

bors commented Sep 1, 2016

bors commented Sep 1, 2016

nikomatsakis commented Sep 3, 2016

nikomatsakis commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

alexcrichton commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

Fix soundness bug described in #29859 #35745

Fix soundness bug described in #29859 #35745

Conversation

jroesch commented Aug 17, 2016 • edited Loading

rust-highfive commented Aug 17, 2016

bors commented Aug 17, 2016

nikomatsakis Aug 17, 2016

Choose a reason for hiding this comment

nikomatsakis Aug 18, 2016

Choose a reason for hiding this comment

nikomatsakis commented Aug 18, 2016

bors commented Aug 18, 2016

jroesch commented Aug 18, 2016

bors commented Aug 18, 2016

jroesch commented Aug 19, 2016 • edited Loading

alexcrichton commented Aug 20, 2016

jroesch commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

nikomatsakis commented Aug 22, 2016

bors commented Aug 22, 2016

bors commented Aug 22, 2016

bors commented Aug 22, 2016

jroesch commented Aug 29, 2016

jroesch commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

arielb1 commented Aug 29, 2016

bors commented Sep 1, 2016

bors commented Sep 1, 2016

nikomatsakis commented Sep 3, 2016

nikomatsakis commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

alexcrichton commented Sep 8, 2016

bors commented Sep 8, 2016

bors commented Sep 8, 2016

jroesch commented Aug 17, 2016 •

edited

Loading

jroesch commented Aug 19, 2016 •

edited

Loading