Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GNU make files for arm-unknown-linux-musleabi #35427

Merged
merged 2 commits into from
Aug 15, 2016

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Aug 6, 2016

For Yocto (Embedded Linux meta distro) Rust is provided via the meta-rust layer. In this project there have been patches to add arm-unknown-linux-musleabi. Rust recently acquired that support via #35060 but only for rustbuild. meta-rust is currently only able to build Rust support with the existing GNU Makefiles. This adds arm-unknown-linux-musleabi support to Rust for the GNU Makefiles until meta-rust is able to sort out why using rustbuild does not work for it.

/cc @srwalter @derekstraka @jmesmon @japaric

Steven Walter and others added 2 commits August 6, 2016 13:26
The arm-unknown-linux-musleabi target used in meta-rust for Yocto didn't
explicitly set the arch to ARMv6 and soft float but was instead done via
target spec files and never had the compiler running on the target.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@codyps
Copy link
Contributor

codyps commented Aug 6, 2016

Related: #34788

@japaric
Copy link
Member

japaric commented Aug 6, 2016

I think this is going to need to copy this part of x86_64-unknown-linux-musl because this target also links statically and crt*.o need to be included in the packaged sysroot.

@alexcrichton are you OK with merging this? We are not going to test or use this file in our build bots.

meta-rust is able to sort out why using rustbuild does not work for it.

@cardoe is there are an issue for this? What sort of problem are you encountering?

@alexcrichton
Copy link
Member

Yeah this seems fine to me to add. The makefiles are hopefully all on their way out with rustbuild entering the picture but in the meantime no need to actively turn down something like this.

@cardoe does this patch work for you? There's some points @japaric mentioned but if it works then it seems fine to merge to me.

@nikomatsakis
Copy link
Contributor

r? @alexcrichton

This seems pretty squarely out of my purview =)

@cardoe
Copy link
Contributor Author

cardoe commented Aug 14, 2016

@alexcrichton It works to build cross compiled binaries for ARM musl but I have not attempted to run an ARM musl rustc.

@alexcrichton
Copy link
Member

Ok, thanks @cardoe!

@bors: r+ 5f606f0

@bors
Copy link
Contributor

bors commented Aug 15, 2016

⌛ Testing commit 5f606f0 with merge 47e6da2...

bors added a commit that referenced this pull request Aug 15, 2016
add GNU make files for arm-unknown-linux-musleabi

For Yocto (Embedded Linux meta distro) Rust is provided via the [meta-rust layer](https://github.com/meta-rust/meta-rust). In this project there have been patches to add `arm-unknown-linux-musleabi`. Rust recently acquired that support via #35060 but only for rustbuild. meta-rust is currently only able to build Rust support with the existing GNU Makefiles. This adds `arm-unknown-linux-musleabi` support to Rust for the GNU Makefiles until meta-rust is able to sort out why using rustbuild does not work for it.

/cc @srwalter @derekstraka @jmesmon @japaric
@bors bors merged commit 5f606f0 into rust-lang:master Aug 15, 2016
@cardoe cardoe deleted the arm-musl-targets branch August 16, 2016 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants