Doc: explain why Box/Rc/Arc methods do not take self #35418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
/cc @GuillaumeGomez |
|
Sorry, not very available this week. |
|
☔ The latest upstream changes (presumably #35764) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -71,6 +71,12 @@ const MAX_REFCOUNT: usize = (isize::MAX) as usize; | |||
| /// does not use atomics, making it both thread-unsafe as well as significantly | |||
| /// faster when updating the reference count. | |||
| /// | |||
| /// Note: as for `Rc<T>`, the inherent methods defined on `Arc<T>` are all | |||
There was a problem hiding this comment.
Can you drop the "as for Rc<T>" here? I think it's more confusing than it's worth.
|
r=me modulo small nit! |
This can be confusing for newcomers, especially due to the argument name "this".
|
done, thanks for review! |
|
@bors: r=aturon rollup |
|
📌 Commit a068fc7 has been approved by |
|
⌛ Testing commit a068fc7 with merge 8746423... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors retry |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 29, 2016
Doc: explain why Box/Rc/Arc methods do not take self This can be confusing for newcomers, especially due to the argument name `this` that is used for Rc and Arc.
bors
added a commit
that referenced
this pull request
Aug 29, 2016
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 30, 2016
Doc: explain why Box/Rc/Arc methods do not take self This can be confusing for newcomers, especially due to the argument name `this` that is used for Rc and Arc.
bors
added a commit
that referenced
this pull request
Aug 30, 2016
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 30, 2016
Doc: explain why Box/Rc/Arc methods do not take self This can be confusing for newcomers, especially due to the argument name `this` that is used for Rc and Arc.
bors
added a commit
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be confusing for newcomers, especially due to the argument name
thisthat is used for Rc and Arc.