Set label for unreachable pattern #35297
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Great! The one change I'd recommend is that "this is unreachable pattern" should be either "unreachable pattern" (as in the issue) or "this is an unreachable pattern", which reads better. Pick either one you want, and I'd be happy to approve. |
|
@jonathandturner Thanks. Changed it to "this is an unreachable pattern" |
|
@bors r+ rollup |
|
📌 Commit 034e659 has been approved by |
Set label for unreachable pattern Part of rust-lang#35233 Fixes rust-lang#35190 r? @jonathandturner
Set label for unreachable pattern Part of rust-lang#35233 Fixes rust-lang#35190 r? @jonathandturner
Set label for unreachable pattern Part of rust-lang#35233 Fixes rust-lang#35190 r? @jonathandturner
Set label for unreachable pattern Part of rust-lang#35233 Fixes rust-lang#35190 r? @jonathandturner
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
Part of #35233
Fixes #35190
r? @jonathandturner