Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message for E0166 #35288

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Update error message for E0166 #35288

merged 1 commit into from
Aug 6, 2016

Conversation

Roybie
Copy link
Contributor

@Roybie Roybie commented Aug 4, 2016

Fixes #35271 as part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Seems good for me.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

@Roybie - would you mind also updating test/compile-fail/E0166.rs? After that, I'd be happy to approve.

@Roybie
Copy link
Contributor Author

Roybie commented Aug 5, 2016

@jonathandturner done!

@GuillaumeGomez
Copy link
Member

Please squash your commit.

@Roybie Roybie force-pushed the 35271-E0166-update-error-format branch from a842672 to 5eebb92 Compare August 5, 2016 14:08
@Roybie
Copy link
Contributor Author

Roybie commented Aug 5, 2016

@GuillaumeGomez sorry about that, squashed!

@GuillaumeGomez
Copy link
Member

@Roybie: Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit 5eebb92 has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
Rollup merge of rust-lang#35288 - Roybie:35271-E0166-update-error-for…
6556ffd 
…mat, r=GuillaumeGomez

Update error message for E0166

Fixes rust-lang#35271 as part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 5, 2016
Closed
bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35397 - jonathandturner:rollup, r=jonathandturner
43446fc 
Rollup of 18 pull requests

- Successful merges: #34916, #35287, #35288, #35331, #35353, #35356, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35394
- Failed merges: #35395
@eddyb eddyb mentioned this pull request Aug 6, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this pull request Aug 6, 2016
@eddyb
Rollup merge of rust-lang#35288 - Roybie:35271-E0166-update-error-for…
bb1ff9d 
…mat, r=GuillaumeGomez

Update error message for E0166

Fixes rust-lang#35271 as part of rust-lang#35233.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35407 - eddyb:rollup, r=eddyb
444ff9f 
Rollup of 21 pull requests

- Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394
- Failed merges: #35331, #35395
@bors bors merged commit 5eebb92 into rust-lang:master Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Roybie @rust-highfive @GuillaumeGomez @sophiajt @bors