-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #34819
Merged
Merged
Rollup of 7 pull requests #34819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @steveklabnik The referenced code https://github.com/thestinger/rust-snappy can not work. Maybe it's the old rust version? I do not know. So I try to rewrite these test cases. If it is not what you originally meaning, just ignored it.
@bors: r+ p=1 |
📌 Commit 3aad6ab has been approved by |
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
⌛ Testing commit 3aad6ab with merge 7e82241... |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
Use `ptr::{null, null_mut}` instead of `0 as *{const, mut}`
…eveklabnik Improve arc doc, fixing rust-lang#32905 As issue rust-lang#32905 detailed, I moved part of the module doc to the struct doc, and fixed some small places in the `alloc::arc`.
doc: Mention that writeln! and println! always use LF Fixes rust-lang#34697 I'm not really satisfied with the wording, but I didn't have a better idea. Suggestions welcome.
…laumeGomez Add doc example for `std::process::ExitStatus::success`. None
doc: ffi referenced rust-snappy can not compile r? @steveklabnik The referenced code https://github.com/thestinger/rust-snappy can not work. Maybe it's the old rust version? I do not know. So I try to rewrite these test cases. If it is not what you originally meaning, just ignored it.
Add examples for FpCategory Fixes rust-lang#29364. r? @steveklabnik
Mention where `std::vec` structs originate from. None
@bors: r+ p=1 |
📌 Commit 8959374 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptr::{null, null_mut}
instead of0 as *{const, mut}
#34456, Improve arc doc, fixing #32905 #34733, doc: Mention that writeln! and println! always use LF #34777, Add doc example forstd::process::ExitStatus::success
. #34794, doc: ffi referenced rust-snappy can not compile #34799, Add examples for FpCategory #34804, Mention wherestd::vec
structs originate from. #34818